Plumbs ::didCompleteSwapBuffers in CompositorCC

ui/gfx/compositor/compositor_cc.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/compositor/compositor_cc.h"
 
 #include "base/command_line.h"
 #include "third_party/skia/include/images/SkImageEncoder.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCompositor.h"
@@ skipping 255 matching lines @@
   if (!command_line->HasSwitch(switches::kDisableUIVsync)) {
     context->makeContextCurrent();
     gfx::GLContext* gl_context = gfx::GLContext::GetCurrent();
     gl_context->SetSwapInterval(1);
     gl_context->ReleaseCurrent(NULL);
   }
 
   return context;
 }
 
+void CompositorCC::didCompleteSwapBuffers() {
+  Compositor::ScheduleDraw();

[piman, 2012/01/03 22:35:54]

I don't understand why we're doing this here. It sounds like this would force
compositing in a loop.
I would assume what we want to do here is run the NotifyEnd observer callbacks
(instead of in Compositor::Draw)

[pkotwicz, 2012/01/03 22:42:18]

Compositor::ScheduleDraw is pretty much the same as what you suggest. I can call
NotifyEnd directly and make NotifyEnd protected

+}
+
 void CompositorCC::didRebindGraphicsContext(bool success) {
 }
 
 void CompositorCC::scheduleComposite() {
   ScheduleDraw();
 }
 
 void CompositorCC::notifyNeedsComposite() {
   ScheduleDraw();
 }
 
 Compositor* Compositor::Create(CompositorDelegate* owner,
                                gfx::AcceleratedWidget widget,
                                const gfx::Size& size) {
   return new CompositorCC(owner, widget, size);
 }
 
 COMPOSITOR_EXPORT void SetupTestCompositor() {
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kDisableTestCompositor)) {
     test_compositor_enabled = true;
   }
 }
 
 COMPOSITOR_EXPORT void DisableTestCompositor() {
   test_compositor_enabled = false;
 }
 
 }  // namespace ui