Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 9008075: Add shell32 to the delayload list for most gyp projects (Closed)

Created:
8 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add shell32 to the delayload list for most gyp projects I am working on removing cruft (manual binds to shell32) that people have made in /chrome and /base BUG=none TEST=green tree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
8 years, 11 months ago (2012-01-04 19:08:00 UTC) #1
M-A Ruel
IIRC, shell32.dll is always loaded, even in the renderer? So delayloading is solely to simplify ...
8 years, 11 months ago (2012-01-04 19:10:29 UTC) #2
cpu_(ooo_6.6-7.5)
On 2012/01/04 19:10:29, Marc-Antoine Ruel wrote: > IIRC, shell32.dll is always loaded, even in the ...
8 years, 11 months ago (2012-01-04 19:29:59 UTC) #3
cpu_(ooo_6.6-7.5)
(hit return too soon) I plan to look at removing shell calls out of the ...
8 years, 11 months ago (2012-01-04 19:31:04 UTC) #4
M-A Ruel
8 years, 11 months ago (2012-01-04 19:31:21 UTC) #5
On 2012/01/04 19:29:59, cpu wrote:
> On 2012/01/04 19:10:29, Marc-Antoine Ruel wrote:
> > IIRC, shell32.dll is always loaded, even in the renderer? So delayloading is
> > solely to simplify calling functions not implemented on XP?
> 
> Correct. It might speed up renderer startup my a microsecond because shell32
has
> a ton of dependent dlls.

Actually it's the reverse since the function lookups become faulty instead of
being looked up at loading time. No biggies.

lgtm

Powered by Google App Engine
This is Rietveld 408576698