Issue 9008061: Re-remove ReleasePointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9008061: Re-remove ReleasePointer. (Closed)

Created:
8 years, 11 months ago by dcheng

Modified:
8 years, 11 months ago

Reviewers:
awong

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-remove ReleasePointer. This was accidentally reintroduced in r116250. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116367

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	base/task.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

8 years, 11 months ago (2012-01-04 19:14:35 UTC) #2

LGTM

oops. Thanks for fixing.

On Wed, Jan 4, 2012 at 1:46 AM, <dcheng@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Re-remove ReleasePointer.
>
> This was accidentally reintroduced in r116250.
>
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/9008061/<http://codereview.chromium.org/9008...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M base/task.h
>
>
> Index: base/task.h
> diff --git a/base/task.h b/base/task.h
> index 571f2748c7014da534d82432b8d18e**2067497730..**
> a310e0d4f0d53fce9f0ad8587fa634**982b42af90 100644
> --- a/base/task.h
> +++ b/base/task.h
> @@ -61,11 +61,6 @@ void DeletePointer(T* obj) {
>   delete obj;
>  }
>
> -template<typename T>
> -void ReleasePointer(T* obj) {
> -  obj->Release();
> -}
> -
>  namespace base {
>
>  // ScopedClosureRunner is akin to scoped_ptr for Closures. It ensures
> that the
>
>
>

Expand Messages | Collapse Messages