Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: build/common.gypi

Issue 9007051: roll clang 146361:147225 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: -Wno-format on linux Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/scripts/update.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 8a147430fd01993c466884cf66b39a235e5aac88..a8ec0770bceff10803129072736c3176fd5bb458 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1962,6 +1962,9 @@
# This (rightyfully) complains about 'override', which we use
# heavily.
'-Wno-c++11-extensions',
+ # TODO(thakis): Reenable this once clang stops complaining about
+ # %as in format strings.
+ '-Wno-format',
Nico 2011/12/24 01:22:52 This is for this line in chrome/browser/memory_det
],
'cflags!': [
# Clang doesn't seem to know know this flag.
@@ -2294,11 +2297,11 @@
'CC': '$(SOURCE_ROOT)/<(clang_dir)/clang',
'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++',
- # Don't use -Wc++0x-extensions, which Xcode 4 enables by default
- # when buliding with clang. This warning is triggered when the
- # override keyword is used via the OVERRIDE macro from
- # base/compiler_specific.h.
- 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
+ # Don't use -Wc++0x-extensions, which Xcode 4 enables by default
+ # when buliding with clang. This warning is triggered when the
+ # override keyword is used via the OVERRIDE macro from
+ # base/compiler_specific.h.
+ 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
'WARNING_CFLAGS': [
« no previous file with comments | « no previous file | tools/clang/scripts/update.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698