Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9007010: Remove the nested #ifdef ADDRESS_SANITIZER (Closed)

Created:
9 years ago by Alexander Potapenko
Modified:
9 years ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove the nested #ifdef ADDRESS_SANITIZER Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115130

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M base/process_util_unittest.cc View 1 3 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
Please take a look
9 years ago (2011-12-20 14:30:05 UTC) #1
Alexander Potapenko
Adding M-A, as Will is on a vacation
9 years ago (2011-12-20 14:33:06 UTC) #2
M-A Ruel
http://codereview.chromium.org/9007010/diff/1/base/process_util_unittest.cc File base/process_util_unittest.cc (right): http://codereview.chromium.org/9007010/diff/1/base/process_util_unittest.cc#newcode898 base/process_util_unittest.cc:898: #if !defined(OS_ANDROID) && !defined(OS_OPENBSD) && !defined(ADDRESS_SANITIZER) Actually, move all ...
9 years ago (2011-12-20 14:42:45 UTC) #3
Alexander Potapenko
http://codereview.chromium.org/9007010/diff/1/base/process_util_unittest.cc File base/process_util_unittest.cc (right): http://codereview.chromium.org/9007010/diff/1/base/process_util_unittest.cc#newcode898 base/process_util_unittest.cc:898: #if !defined(OS_ANDROID) && !defined(OS_OPENBSD) && !defined(ADDRESS_SANITIZER) On 2011/12/20 14:42:45, ...
9 years ago (2011-12-20 15:14:09 UTC) #4
M-A Ruel
lgtm
9 years ago (2011-12-20 15:18:17 UTC) #5
willchan no longer on Chromium
9 years ago (2011-12-20 20:14:33 UTC) #6 
LGTM

On Tue, Dec 20, 2011 at 7:18 AM, <maruel@chromium.org> wrote:

> lgtm
>
>
>
>
http://codereview.chromium.**org/9007010/<http://codereview.chromium.org/9007...
>

Powered by Google App Engine
This is Rietveld 408576698