Issue 9006051: Add InternalArrayCodeGeneric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9006051: Add InternalArrayCodeGeneric (Closed)

Created:
8 years, 12 months ago by danno

Modified:
8 years, 12 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add InternalArrayCodeGeneric R=whesse@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=10308

Patch Set 1 #

Patch Set 2 : remove unchanged file #

Patch Set 3 : review feedback #

Patch Set 4 : more reivew feedback #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -19 lines)			Patch
M	src/arm/builtins-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/builtins.cc	View	1 2	6 chunks	+29 lines, -16 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/builtins-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

8 years, 12 months ago (2011-12-28 15:41:08 UTC) #2

LGTM.

We don't often use references in the C++ code.  Was this change required by the
addition of const, or is it for inlining and efficiency?

Note that the Arguments parameter of a runtime function is constructed by the
CEntryStub, and may even be solely in registers (I think) on X64.

Expand Messages | Collapse Messages