compiler/java/com/google/dart/compiler/parser/DartParser.java - Issue 9006033: Issue926: NPE while traversing nodes + invalid string interpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 9006033: Issue926: NPE while traversing nodes + invalid string interpolation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Adding test Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/java/com/google/dart/compiler/parser/DartParser.java

diff --git a/compiler/java/com/google/dart/compiler/parser/DartParser.java b/compiler/java/com/google/dart/compiler/parser/DartParser.java

index eda9237afbf361346914e95d8dcaf53123ffec99..ddc622f52d8ea5e0311a705a2223e3e2fc926df3 100644

--- a/compiler/java/com/google/dart/compiler/parser/DartParser.java

+++ b/compiler/java/com/google/dart/compiler/parser/DartParser.java

@@ -2125,7 +2125,11 @@ public class DartParser extends CompletionHooksParserBase {

}

case EOS: {

reportError(position(), ParserErrorCode.INCOMPLETE_STRING_LITERAL);

- return done(null);

+ if(strings.size() == expressions.size()) {

+ strings.add(DartStringLiteral.get(""));

+ }

+ inString = false;

+ break;

}

default: {

reportError(position(), ParserErrorCode.UNEXPECTED_TOKEN_IN_STRING_INTERPOLATION,

« no previous file with comments | « no previous file | tests/language/src/StringInterpolateNPENegativeTest.dart » ('j') | tests/language/src/StringInterpolateNPENegativeTest.dart » ('J')