Coverity fixes for uninitialized vars

Coverity fixes for uninitialized vars


CID=102348, 102334, 100563, 102456, 102012, 101525, 101526, 101330, 101329
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116003

[csilv, 2011-12-20 23:44:38]

lgtm

[groby-ooo-7-16, 2011-12-22 20:08:49]

piman: OWNERS stamp for content/plugin, gpu,ppapi please
joi: OWNERS stamp for content/public please
ben: OWNERS stamp for ui/base please

[Jói, 2011-12-22 20:30:44]

LGTM for content/public.

On Thu, Dec 22, 2011 at 8:08 PM,  <groby@chromium.org> wrote:
> Reviewers: csilv, piman, Jói, Ben Goodger (Google),
>
> Message:
> piman: OWNERS stamp for content/plugin, gpu,ppapi please
> joi: OWNERS stamp for content/public please
> ben: OWNERS stamp for ui/base please
>
> Description:
> Coverity fixes for uninitialized vars
>
>
> CID=102348, 102334, 100563, 102456, 102012, 101525, 101526, 101330, 101329
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/9006028/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M content/plugin/plugin_main_linux.cc
>  M content/public/common/show_desktop_notification_params.cc
>  M gpu/command_buffer/service/command_buffer_service.cc
>  M ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc
>  M ppapi/proxy/plugin_var_tracker.cc
>  M ppapi/proxy/ppb_var_deprecated_proxy.cc
>  M ui/base/win/events_win.cc
>
>
> Index: content/plugin/plugin_main_linux.cc
> diff --git a/content/plugin/plugin_main_linux.cc
> b/content/plugin/plugin_main_linux.cc
> index
>
6bb9da7dd84012349bdadbfc0c68df26c9bb2a4c..b973ce8d230ddedf3e818479f5d26f01b22ee09c
> 100644
> --- a/content/plugin/plugin_main_linux.cc
> +++ b/content/plugin/plugin_main_linux.cc
> @@ -30,7 +30,7 @@ void SignalHandler(int signum, siginfo_t* info, void*
> void_context) {
>     // need to be careful to handle threads etc. properly.
>
>     struct sigaction sa;
> -    sa.sa_flags = 0;
> +    memset(&sa, 0, sizeof(sa));
>     sigemptyset(&sa.sa_mask);
>     sa.sa_handler = SIG_DFL;
>     sigaction(signum, &sa, NULL);
> Index: content/public/common/show_desktop_notification_params.cc
> diff --git a/content/public/common/show_desktop_notification_params.cc
> b/content/public/common/show_desktop_notification_params.cc
> index
>
e93f7cc5dccdd57295e288e441ddfd57656b8533..b7e35a6624d5e614442799bfecb3973b1ff6d10a
> 100644
> --- a/content/public/common/show_desktop_notification_params.cc
> +++ b/content/public/common/show_desktop_notification_params.cc
> @@ -7,7 +7,8 @@
>  namespace content {
>
>  ShowDesktopNotificationHostMsgParams::ShowDesktopNotificationHostMsgParams()
> -    : is_html(false), notification_id(0) {
> +    : is_html(false), direction(WebKit::WebTextDirectionDefault),
> +      notification_id(0) {
>  }
>
>  ShowDesktopNotificationHostMsgParams::~ShowDesktopNotificationHostMsgParams()
> {
> Index: gpu/command_buffer/service/command_buffer_service.cc
> diff --git a/gpu/command_buffer/service/command_buffer_service.cc
> b/gpu/command_buffer/service/command_buffer_service.cc
> index
>
4047d1c94081a91a2502e3cfff79b404142f814c..f196259b77386746e1af8282e83d291f362bd1ac
> 100644
> --- a/gpu/command_buffer/service/command_buffer_service.cc
> +++ b/gpu/command_buffer/service/command_buffer_service.cc
> @@ -20,7 +20,8 @@ CommandBufferService::CommandBufferService()
>       put_offset_(0),
>       token_(0),
>       generation_(0),
> -      error_(error::kNoError) {
> +      error_(error::kNoError),
> +      context_lost_reason_(error::kUnknown) {
>   // Element zero is always NULL.
>   registered_objects_.push_back(Buffer());
>  }
> Index: ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc
> diff --git
> a/ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc
> b/ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc
> index
>
20cfe0c83a5f61e3b237cf104e5ac2cf71596f90..3d32513f37067021ae6f56a39e60818434d6d7c8
> 100644
> --- a/ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc
> +++ b/ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc
> @@ -40,7 +40,7 @@ scoped_refptr<PluginResource>
> PluginResourceTracker::GetExistingResource(
>     return result->second.resource;
>  }
>
> -PluginResourceTracker::PluginResourceTracker() {
> +PluginResourceTracker::PluginResourceTracker() : last_id_(0) {
>  }
>
>  void PluginResourceTracker::AddResource(PluginResource* resource,
> Index: ppapi/proxy/plugin_var_tracker.cc
> diff --git a/ppapi/proxy/plugin_var_tracker.cc
> b/ppapi/proxy/plugin_var_tracker.cc
> index
>
a5f499af437e070813296104539fd25f5369058a..97bfcd7e9a1941b0ce028489d1efb11a348cc1e3
> 100644
> --- a/ppapi/proxy/plugin_var_tracker.cc
> +++ b/ppapi/proxy/plugin_var_tracker.cc
> @@ -235,8 +235,7 @@ PP_Var
> PluginVarTracker::GetOrCreateObjectVarID(ProxyObjectVar* object) {
>     object->AssignVarID(var_id);
>   }
>
> -  PP_Var ret;
> -  ret.type = PP_VARTYPE_OBJECT;
> +  PP_Var ret = { PP_VARTYPE_OBJECT };
>   ret.value.as_id = var_id;
>   return ret;
>  }
> Index: ppapi/proxy/ppb_var_deprecated_proxy.cc
> diff --git a/ppapi/proxy/ppb_var_deprecated_proxy.cc
> b/ppapi/proxy/ppb_var_deprecated_proxy.cc
> index
>
7cf479090836cb6d2f742e67795ea776192ab917..2637a0235a0669047e504b7df947bc60f1e56808
> 100644
> --- a/ppapi/proxy/ppb_var_deprecated_proxy.cc
> +++ b/ppapi/proxy/ppb_var_deprecated_proxy.cc
> @@ -343,8 +343,7 @@ bool PPB_Var_Deprecated_Proxy::OnMessageReceived(const
> IPC::Message& msg) {
>
>  void PPB_Var_Deprecated_Proxy::OnMsgAddRefObject(int64 object_id,
>                                                  int* /* unused */) {
> -  PP_Var var;
> -  var.type = PP_VARTYPE_OBJECT;
> +  PP_Var var = { PP_VARTYPE_OBJECT };
>   var.value.as_id = object_id;
>   ppb_var_impl_->AddRef(var);
>  }
> @@ -504,8 +503,7 @@ void
> PPB_Var_Deprecated_Proxy::SetAllowPluginReentrancy() {
>  }
>
>  void PPB_Var_Deprecated_Proxy::DoReleaseObject(int64 object_id) {
> -  PP_Var var;
> -  var.type = PP_VARTYPE_OBJECT;
> +  PP_Var var = { PP_VARTYPE_OBJECT };
>   var.value.as_id = object_id;
>   ppb_var_impl_->Release(var);
>  }
> Index: ui/base/win/events_win.cc
> diff --git a/ui/base/win/events_win.cc b/ui/base/win/events_win.cc
> index
>
c745526a6c4ebbfdcea8d1205d6be022eecdfaa0..200acd943bbc42070e468e1d64492c5393ee0f3d
> 100644
> --- a/ui/base/win/events_win.cc
> +++ b/ui/base/win/events_win.cc
> @@ -265,10 +265,8 @@ void UpdateDeviceList() {
>  }
>
>  base::NativeEvent CreateNoopEvent() {
> -  MSG event;
> +  MSG event = { NULL };
>   event.message = WM_USER;
> -  event.wParam = 0;
> -  event.lParam = 0;
>   return event;
>  }
>
>
>

[Ben Goodger (Google), 2011-12-22 21:21:05]

lgtm

[piman, 2011-12-27 17:46:20]

lgtm

http://codereview.chromium.org/9006028/diff/1001/content/plugin/plugin_main_l...
File content/plugin/plugin_main_linux.cc (right):

http://codereview.chromium.org/9006028/diff/1001/content/plugin/plugin_main_l...
content/plugin/plugin_main_linux.cc:33: memset(&sa, 0, sizeof(sa));
Do you think struct sigaction sa = {NULL}; would be simpler?

[groby-ooo-7-16, 2011-12-27 17:50:33]

I actually prefer the assignment idiom - just modelled the memset after other
sigaction uses. But since I have owner approval now.... :) (Off to change it)

[groby-ooo-7-16, 2011-12-28 20:36:03]

http://codereview.chromium.org/9006028/diff/1001/content/plugin/plugin_main_l...
File content/plugin/plugin_main_linux.cc (right):

http://codereview.chromium.org/9006028/diff/1001/content/plugin/plugin_main_l...
content/plugin/plugin_main_linux.cc:33: memset(&sa, 0, sizeof(sa));
On 2011/12/27 17:46:20, piman wrote:
> Do you think struct sigaction sa = {NULL}; would be simpler?

Done.

[piman, 2011-12-28 20:38:35]

lgtm

[commit-bot: I haz the power, 2011-12-29 00:26:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/9006028/10012

[commit-bot: I haz the power, 2011-12-29 22:14:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/9006028/10012

[commit-bot: I haz the power, 2011-12-29 23:36:47]

Change committed as 116003