Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 9006027: Rip Out the Sidebar API (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
===================================================================
--- chrome/browser/resources/file_manager/js/file_manager.js (revision 115251)
+++ chrome/browser/resources/file_manager/js/file_manager.js (working copy)
@@ -575,7 +575,7 @@
var path = entry.fullPath;
if (path == ARCHIVE_DIRECTORY || path == REMOVABLE_DIRECTORY) {
// All removable devices and mounted archives are considered
- // roots, and are shown in the sidebar.
+ // roots.
util.forEachDirEntry(entry, onRootFound);
} else {
onRootFound(entry);
@@ -763,10 +763,6 @@
this.okButton_.addEventListener('click', this.onOk_.bind(this));
this.cancelButton_.addEventListener('click', this.onCancel_.bind(this));
- this.dialogDom_.querySelector('div.open-sidebar').addEventListener(
- 'click', this.onToggleSidebar_.bind(this));
- this.dialogDom_.querySelector('div.close-sidebar').addEventListener(
- 'click', this.onToggleSidebar_.bind(this));
this.dialogContainer_ = this.dialogDom_.querySelector('.dialog-container');
this.dialogDom_.querySelector('button.detail-view').addEventListener(
@@ -3665,16 +3661,6 @@
}, 0);
};
- FileManager.prototype.onToggleSidebar_ = function(event) {
- if (this.dialogContainer_.hasAttribute('sidebar')) {
- this.dialogContainer_.removeAttribute('sidebar');
- } else {
- this.dialogContainer_.setAttribute('sidebar', 'sidebar');
- }
- // TODO(dgozman): make table header css-resizable.
- setTimeout(this.onResize_.bind(this), 300);
- };
-
FileManager.prototype.onNewFolderCommand_ = function(event) {
var self = this;

Powered by Google App Engine
This is Rietveld 408576698