Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3254)

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 9006027: Rip Out the Sidebar API (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_manifests_unittest.cc
===================================================================
--- chrome/common/extensions/extension_manifests_unittest.cc (revision 116830)
+++ chrome/common/extensions/extension_manifests_unittest.cc (working copy)
@@ -25,7 +25,6 @@
#include "chrome/common/extensions/extension_action.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_error_utils.h"
-#include "chrome/common/extensions/extension_sidebar_defaults.h"
#include "chrome/common/extensions/file_browser_handler.h"
#include "chrome/common/extensions/url_pattern.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -546,37 +545,6 @@
EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts());
}
-TEST_F(ExtensionManifestTest, Sidebar) {
- LoadAndExpectError("sidebar.json",
- errors::kExperimentalFlagRequired);
-
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
- LoadAndExpectError("sidebar_no_permissions.json",
- errors::kSidebarExperimental);
-
- LoadAndExpectError("sidebar_icon_empty.json",
- errors::kInvalidSidebarDefaultIconPath);
- LoadAndExpectError("sidebar_icon_invalid_type.json",
- errors::kInvalidSidebarDefaultIconPath);
- LoadAndExpectError("sidebar_page_empty.json",
- errors::kInvalidSidebarDefaultPage);
- LoadAndExpectError("sidebar_page_invalid_type.json",
- errors::kInvalidSidebarDefaultPage);
- LoadAndExpectError("sidebar_title_invalid_type.json",
- errors::kInvalidSidebarDefaultTitle);
-
- scoped_refptr<Extension> extension(LoadAndExpectSuccess("sidebar.json"));
- ASSERT_TRUE(extension->sidebar_defaults() != NULL);
- EXPECT_EQ(extension->sidebar_defaults()->default_title(),
- ASCIIToUTF16("Default title"));
- EXPECT_EQ(extension->sidebar_defaults()->default_icon_path(),
- "icon.png");
- EXPECT_EQ(extension->url().spec() + "sidebar.html",
- extension->sidebar_defaults()->default_page().spec());
-}
-
TEST_F(ExtensionManifestTest, BackgroundPermission) {
LoadAndExpectError("background_permission.json",
errors::kBackgroundPermissionNeeded);
« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | chrome/common/extensions/extension_sidebar_defaults.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698