Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 9006027: Rip Out the Sidebar API (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/sidebar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
===================================================================
--- chrome/browser/ui/cocoa/browser_window_controller_unittest.mm (revision 116830)
+++ chrome/browser/ui/cocoa/browser_window_controller_unittest.mm (working copy)
@@ -53,10 +53,6 @@
return static_cast<NSSplitView*>([devToolsController_ view]);
}
-- (NSView*)sidebarView {
- return [sidebarController_ view];
-}
-
- (BOOL)bookmarkBarVisible {
return [bookmarkBarController_ isVisible];
}
@@ -609,20 +605,6 @@
EXPECT_GT(findBar_index, bookmark_index);
}
-// Tests that the sidebar view and devtools view are both non-opaque.
-TEST_F(BrowserWindowControllerTest, TestSplitViewsAreNotOpaque) {
- // Add a subview to the sidebar view to mimic what happens when a tab is added
- // to the window. NSSplitView only marks itself as non-opaque when one of its
- // subviews is non-opaque, so the test will not pass without this subview.
- scoped_nsobject<NSView> view(
- [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
- [[controller_ sidebarView] addSubview:view];
-
- EXPECT_FALSE([[controller_ tabContentArea] isOpaque]);
- EXPECT_FALSE([[controller_ devToolsView] isOpaque]);
- EXPECT_FALSE([[controller_ sidebarView] isOpaque]);
-}
-
// Tests that status bubble's base frame does move when devTools are docked.
TEST_F(BrowserWindowControllerTest, TestStatusBubblePositioning) {
ASSERT_EQ(1U, [[[controller_ devToolsView] subviews] count]);
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/sidebar_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698