Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7809)

Unified Diff: chrome/common/extensions/extension.h

Issue 9006027: Rip Out the Sidebar API (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
===================================================================
--- chrome/common/extensions/extension.h (revision 115368)
+++ chrome/common/extensions/extension.h (working copy)
@@ -29,7 +29,6 @@
class ExtensionAction;
class ExtensionResource;
-class ExtensionSidebarDefaults;
class FileBrowserHandler;
class SkBitmap;
class Version;
@@ -231,7 +230,6 @@
// Max size (both dimensions) for browser and page actions.
static const int kPageActionIconMaxSize;
static const int kBrowserActionIconMaxSize;
- static const int kSidebarIconMaxSize;
// Valid schemes for web extent URLPatterns.
static const int kValidWebExtentSchemes;
@@ -511,9 +509,6 @@
const UserScriptList& content_scripts() const { return content_scripts_; }
ExtensionAction* page_action() const { return page_action_.get(); }
ExtensionAction* browser_action() const { return browser_action_.get(); }
- ExtensionSidebarDefaults* sidebar_defaults() const {
- return sidebar_defaults_.get();
- }
const FileBrowserHandlerList* file_browser_handlers() const {
return file_browser_handlers_.get();
}
@@ -675,11 +670,6 @@
FileBrowserHandler* LoadFileBrowserHandler(
const base::DictionaryValue* file_browser_handlers, string16* error);
- // Helper method to load an ExtensionSidebarDefaults from the sidebar manifest
- // entry.
- ExtensionSidebarDefaults* LoadExtensionSidebarDefaults(
- const base::DictionaryValue* sidebar, string16* error);
-
// Returns true if the extension has more than one "UI surface". For example,
// an extension that has a browser action and a page action.
bool HasMultipleUISurfaces() const;
@@ -780,9 +770,6 @@
// The extension's file browser actions, if any.
scoped_ptr<FileBrowserHandlerList> file_browser_handlers_;
- // The extension's sidebar, if any.
- scoped_ptr<ExtensionSidebarDefaults> sidebar_defaults_;
-
// Optional list of NPAPI plugins and associated properties.
std::vector<PluginInfo> plugins_;

Powered by Google App Engine
This is Rietveld 408576698