Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7659)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 9006027: Rip Out the Sidebar API (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
===================================================================
--- chrome/browser/ui/cocoa/browser_window_cocoa.mm (revision 115368)
+++ chrome/browser/ui/cocoa/browser_window_cocoa.mm (working copy)
@@ -14,8 +14,6 @@
#include "chrome/browser/download/download_shelf.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/sidebar/sidebar_container.h"
-#include "chrome/browser/sidebar/sidebar_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#import "chrome/browser/ui/cocoa/browser/avatar_button_controller.h"
@@ -75,9 +73,6 @@
: browser_(browser),
controller_(controller),
confirm_close_factory_(browser) {
- registrar_.Add(
- this, chrome::NOTIFICATION_SIDEBAR_CHANGED,
- content::Source<SidebarManager>(SidebarManager::GetInstance()));
pref_change_registrar_.Init(browser_->profile()->GetPrefs());
pref_change_registrar_.Add(prefs::kShowBookmarkBar, this);
@@ -580,10 +575,6 @@
[controller_ updateBookmarkBarVisibilityWithAnimation:YES];
break;
}
- case chrome::NOTIFICATION_SIDEBAR_CHANGED:
- UpdateSidebarForContents(
- content::Details<SidebarContainer>(details)->tab_contents());
- break;
default:
NOTREACHED(); // we don't ask for anything else!
break;
@@ -601,12 +592,6 @@
return [controller_ window];
}
-void BrowserWindowCocoa::UpdateSidebarForContents(TabContents* tab_contents) {
- if (tab_contents == browser_->GetSelectedTabContents()) {
- [controller_ updateSidebarForContents:tab_contents];
- }
-}
-
void BrowserWindowCocoa::ShowAvatarBubble(TabContents* tab_contents,
const gfx::Rect& rect) {
NSView* view = tab_contents->GetNativeView();

Powered by Google App Engine
This is Rietveld 408576698