Rip Out the Sidebar API

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/i18n/rtl.h"
 #include "base/json/json_value_serializer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_error_utils.h"
-#include "chrome/common/extensions/extension_sidebar_defaults.h"
 #include "chrome/common/extensions/file_browser_handler.h"
 #include "chrome/common/extensions/url_pattern.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "webkit/glue/web_intent_service_data.h"
 
 namespace {
 
 static void AddPattern(URLPatternSet* extent, const std::string& pattern) {
   int schemes = URLPattern::SCHEME_ALL;
@@ skipping 487 matching lines @@
   LoadAndExpectError("devtools_extension_url_invalid_type.json",
       errors::kInvalidDevToolsPage);
 
   scoped_refptr<Extension> extension;
   extension = LoadAndExpectSuccess("devtools_extension.json");
   EXPECT_EQ(extension->url().spec() + "devtools.html",
             extension->devtools_url().spec());
   EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts());
 }
 
-TEST_F(ExtensionManifestTest, Sidebar) {
-  LoadAndExpectError("sidebar.json",
-      errors::kExperimentalFlagRequired);
-
-  CommandLine::ForCurrentProcess()->AppendSwitch(
-      switches::kEnableExperimentalExtensionApis);
-
-  LoadAndExpectError("sidebar_no_permissions.json",
-      errors::kSidebarExperimental);
-
-  LoadAndExpectError("sidebar_icon_empty.json",
-      errors::kInvalidSidebarDefaultIconPath);
-  LoadAndExpectError("sidebar_icon_invalid_type.json",
-      errors::kInvalidSidebarDefaultIconPath);
-  LoadAndExpectError("sidebar_page_empty.json",
-      errors::kInvalidSidebarDefaultPage);
-  LoadAndExpectError("sidebar_page_invalid_type.json",
-      errors::kInvalidSidebarDefaultPage);
-  LoadAndExpectError("sidebar_title_invalid_type.json",
-      errors::kInvalidSidebarDefaultTitle);
-
-  scoped_refptr<Extension> extension(LoadAndExpectSuccess("sidebar.json"));
-  ASSERT_TRUE(extension->sidebar_defaults() != NULL);
-  EXPECT_EQ(extension->sidebar_defaults()->default_title(),
-            ASCIIToUTF16("Default title"));
-  EXPECT_EQ(extension->sidebar_defaults()->default_icon_path(),
-            "icon.png");
-  EXPECT_EQ(extension->url().spec() + "sidebar.html",
-            extension->sidebar_defaults()->default_page().spec());
-}
-
 TEST_F(ExtensionManifestTest, BackgroundPermission) {
   LoadAndExpectError("background_permission.json",
                      errors::kBackgroundPermissionNeeded);
 }
 
 TEST_F(ExtensionManifestTest, OptionsPageInApps) {
   scoped_refptr<Extension> extension;
 
   // Allow options page with absolute URL in hosted apps.
   extension = LoadAndExpectSuccess("hosted_app_absolute_options.json");
@@ skipping 380 matching lines @@
   // This guy is identical to the previous but doesn't ask for any
   // platform-app-only permissions. We should be able to load him and ask
   // questions about his permissions.
   scoped_refptr<Extension> extension(
       LoadAndExpectSuccess("not_platform_app.json"));
   ExtensionAPIPermissionSet apis = extension->GetActivePermissions()->apis();
   for (ExtensionAPIPermissionSet::const_iterator i = apis.begin();
        i != apis.end(); ++i)
     EXPECT_NE(platform_app, info->GetByID(*i)->type_restrictions());
 }