Rip Out the Sidebar API

chrome/browser/ui/cocoa/view_id_util_browsertest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/sidebar/sidebar_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/view_id_util.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 
 // Basic sanity check of ViewID use on the mac.
@@ skipping 11 matching lines @@
     ASSERT_TRUE(root_window_);
     NSView* view = view_id_util::GetView(root_window_, view_id);
     EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id;
   }
 
   void DoTest() {
     // Make sure FindBar is created to test
     // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE.
     browser()->ShowFindBar();
 
-    // Make sure sidebar is created to test VIEW_ID_SIDE_BAR_CONTAINER.
-    const char sidebar_content_id[] = "test_content_id";
-    SidebarManager::GetInstance()->ShowSidebar(
-        browser()->GetSelectedTabContents(), sidebar_content_id);
-    SidebarManager::GetInstance()->ExpandSidebar(
-        browser()->GetSelectedTabContents(), sidebar_content_id);
-
     // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
     browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsOpenDocked,
                                                  true);
     browser()->ToggleDevToolsWindow(DEVTOOLS_TOGGLE_ACTION_INSPECT);
 
     // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
     browser()->window()->GetDownloadShelf()->Show();
 
     // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
     BookmarkModel* bookmark_model = browser()->profile()->GetBookmarkModel();
     if (bookmark_model) {
       if (!bookmark_model->IsLoaded())
         ui_test_utils::WaitForBookmarkModelToLoad(bookmark_model);
 
       bookmark_utils::AddIfNotBookmarked(
           bookmark_model, GURL(chrome::kAboutBlankURL), ASCIIToUTF16("about"));
     }
 
     for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
       // Mac implementation does not support following ids yet.
       if (i == VIEW_ID_STAR_BUTTON ||
           i == VIEW_ID_AUTOCOMPLETE ||
           i == VIEW_ID_CONTENTS_SPLIT ||
-          i == VIEW_ID_SIDE_BAR_SPLIT ||
           i == VIEW_ID_FEEDBACK_BUTTON ||
           i == VIEW_ID_OMNIBOX) {
         continue;
       }
 
       CheckViewID(static_cast<ViewID>(i), true);
     }
 
     CheckViewID(VIEW_ID_TAB, true);
     CheckViewID(VIEW_ID_TAB_STRIP, true);
@@ skipping 27 matching lines @@
     CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), true);
     // VIEW_ID_TAB_LAST should always be available.
     CheckViewID(VIEW_ID_TAB_LAST, true);
   }
 
   // Open the 11th tab.
   browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),
                      NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED);
   CheckViewID(VIEW_ID_TAB_LAST, true);
 }