Issue 9006010: [cros] Vertical align of usernames, password fields and buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9006010: [cros] Vertical align of usernames, password fields and buttons. (Closed)

Created:
9 years ago by Ivan Korotkov

Modified:
9 years ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Vertical align of usernames, password fields and buttons. BUG=chromium-os:21429 TEST=Manual: see bug description Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115129

Patch Set 2 : Sort CSS lines. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/resources/chromeos/login/user_pod_row.css	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm http://codereview.chromium.org/9006010/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css File chrome/browser/resources/chromeos/login/user_pod_row.css (right): http://codereview.chromium.org/9006010/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css#newcode36 chrome/browser/resources/chromeos/login/user_pod_row.css:36: margin-bottom: 10px; nit: alpha-sorting for properties. http://codereview.chromium.org/9006010/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css#newcode133 chrome/browser/resources/chromeos/login/user_pod_row.css:133: ...

9 years ago (2011-12-20 14:43:37 UTC) #2

Ivan Korotkov

9 years ago (2011-12-20 15:12:19 UTC) #3

http://codereview.chromium.org/9006010/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/user_pod_row.css (right):

http://codereview.chromium.org/9006010/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/user_pod_row.css:36: margin-bottom:
10px;
On 2011/12/20 14:43:37, Nikita Kostylev wrote:
> nit: alpha-sorting for properties.

Done.

http://codereview.chromium.org/9006010/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/user_pod_row.css:133: width: 94px;
On 2011/12/20 14:43:37, Nikita Kostylev wrote:
> nit: alpha-sorting for properties.

Done.

Expand Messages | Collapse Messages

Issue 9006010: [cros] Vertical align of usernames, password fields and buttons. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Sort CSS lines. #

Messages