Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 9006003: Refactor and fix feedback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
index c845ca57281afafc7c5ae54ad4d8a3ae4edc9af2..ac3bd333ed9868c851495d95b54053bdb848eadc 100644
--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
@@ -137,25 +137,24 @@ IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestAboutPage) {
//==============================
// chrome://bugreport
//==============================
-// TestBugReportPage fails on chromeos Debug build. crbug.com/105631
+// TestFeedbackPage fails on chromeos Debug build. crbug.com/105631
#if defined(OS_CHROMEOS)
-#define MAYBE_TestBugReportPage DISABLED_TestBugReportPage
+#define MAYBE_TestFeedbackPage DISABLED_TestFeedbackPage
#else
-#define MAYBE_TestBugReportPage TestBugReportPage
+#define MAYBE_TestFeedbackPage TestFeedbackPage
#endif
-IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, MAYBE_TestBugReportPage)
-{
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+ MAYBE_TestFeedbackPage) {
// The bugreport page receives its contents as GET arguments. Here we provide
// a custom, Hebrew typed, description message.
RunBidiCheckerOnPage(
- "chrome://bugreport#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94"
- "&issueType=1");
+ "chrome://feedback#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94");
}
IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
- MAYBE_TestBugReportPage) {
- RunBidiCheckerOnPage("chrome://bugreport#0?description=test&issueType=1");
+ MAYBE_TestFeedbackPage) {
+ RunBidiCheckerOnPage("chrome://feedback#0?description=test");
}
//==============================

Powered by Google App Engine
This is Rietveld 408576698