Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/test/data/webui/bidichecker_tests.js

Issue 9006003: Refactor and fix feedback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2011 -> 2012 Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/url_constants.cc ('k') | chrome/test/functional/special_tabs.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The following test runs the BiDi Checker on the current page with LTR 5 // The following test runs the BiDi Checker on the current page with LTR
6 // base direction. Any bad mixture or RTL and LTR will be reported back 6 // base direction. Any bad mixture or RTL and LTR will be reported back
7 // by this test. 7 // by this test.
8 8
9 function filtersForPage(pageName, isRTL) { 9 function filtersForPage(pageName, isRTL) {
10 // Suppression filters should be added to the object below. You may omit 10 // Suppression filters should be added to the object below. You may omit
11 // either RTL or LTR filters, or may not include filters for your page at all. 11 // either RTL or LTR filters, or may not include filters for your page at all.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 bidichecker.FilterFactory.locationClass('plugin-text') 56 bidichecker.FilterFactory.locationClass('plugin-text')
57 ] 57 ]
58 }, 58 },
59 "chrome://newtab" : { 59 "chrome://newtab" : {
60 "RTL" : [ 60 "RTL" : [
61 // BUG: http://crbug.com/93339 61 // BUG: http://crbug.com/93339
62 bidichecker.FilterFactory.atText("Chrome Web Store"), 62 bidichecker.FilterFactory.atText("Chrome Web Store"),
63 bidichecker.FilterFactory.atText("File Manager") 63 bidichecker.FilterFactory.atText("File Manager")
64 ] 64 ]
65 }, 65 },
66 "chrome://bugreport#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94&issueType=1" : 66 "chrome://feedback#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94" :
67 { 67 {
68 "LTR" : [ 68 "LTR" : [
69 // BUG: http://crbug.com/90835 69 // BUG: http://crbug.com/90835
70 bidichecker.FilterFactory.atText("בדיקה") 70 bidichecker.FilterFactory.atText("בדיקה")
71 ] 71 ]
72 }, 72 },
73 "chrome://bugreport#0?description=test&issueType=1" : { 73 "chrome://feedback#0?description=test" : {
74 "RTL" : [ 74 "RTL" : [
75 // BUG: http://crbug.com/90835 75 // BUG: http://crbug.com/90835
76 bidichecker.FilterFactory.atText("test"), 76 bidichecker.FilterFactory.atText("test"),
77 bidichecker.FilterFactory.atText("stub-user@example.com") 77 bidichecker.FilterFactory.atText("stub-user@example.com")
78 ] 78 ]
79 }, 79 },
80 "chrome://settings/browser" : { 80 "chrome://settings/browser" : {
81 "LTR" : [ 81 "LTR" : [
82 // BUG: http://crbug.com/93702 82 // BUG: http://crbug.com/93702
83 bidichecker.FilterFactory.atText( 83 bidichecker.FilterFactory.atText(
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 prettyErrors += bidiErrors[idx].toString(); 140 prettyErrors += bidiErrors[idx].toString();
141 } 141 }
142 prettyErrors += '\n\n'; 142 prettyErrors += '\n\n';
143 return prettyErrors; 143 return prettyErrors;
144 } 144 }
145 145
146 function runBidiChecker(pageName, isRTL) { 146 function runBidiChecker(pageName, isRTL) {
147 var filters = filtersForPage(pageName, isRTL); 147 var filters = filtersForPage(pageName, isRTL);
148 var bidiErrors = bidichecker.checkPage(isRTL, top.document.body, filters); 148 var bidiErrors = bidichecker.checkPage(isRTL, top.document.body, filters);
149 assertTrue(bidiErrors.length == 0, buildPrettyErrors(bidiErrors)); 149 assertTrue(bidiErrors.length == 0, buildPrettyErrors(bidiErrors));
150 } 150 }
OLDNEW
« no previous file with comments | « chrome/common/url_constants.cc ('k') | chrome/test/functional/special_tabs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698