Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 9006003: Refactor and fix feedback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2011 -> 2012 Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/sad_tab_view.cc ('k') | chrome/browser/ui/webui/bug_report_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h" 5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 //============================== 130 //==============================
131 131
132 // This page isn't localized to an RTL language so we test it only in English. 132 // This page isn't localized to an RTL language so we test it only in English.
133 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestAboutPage) { 133 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestAboutPage) {
134 RunBidiCheckerOnPage(chrome::kChromeUIAboutURL); 134 RunBidiCheckerOnPage(chrome::kChromeUIAboutURL);
135 } 135 }
136 136
137 //============================== 137 //==============================
138 // chrome://bugreport 138 // chrome://bugreport
139 //============================== 139 //==============================
140 // TestBugReportPage fails on chromeos Debug build. crbug.com/105631 140 // TestFeedbackPage fails on chromeos Debug build. crbug.com/105631
141 #if defined(OS_CHROMEOS) 141 #if defined(OS_CHROMEOS)
142 #define MAYBE_TestBugReportPage DISABLED_TestBugReportPage 142 #define MAYBE_TestFeedbackPage DISABLED_TestFeedbackPage
143 #else 143 #else
144 #define MAYBE_TestBugReportPage TestBugReportPage 144 #define MAYBE_TestFeedbackPage TestFeedbackPage
145 #endif 145 #endif
146 146
147 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, MAYBE_TestBugReportPage) 147 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
148 { 148 MAYBE_TestFeedbackPage) {
149 // The bugreport page receives its contents as GET arguments. Here we provide 149 // The bugreport page receives its contents as GET arguments. Here we provide
150 // a custom, Hebrew typed, description message. 150 // a custom, Hebrew typed, description message.
151 RunBidiCheckerOnPage( 151 RunBidiCheckerOnPage(
152 "chrome://bugreport#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94" 152 "chrome://feedback#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94");
153 "&issueType=1");
154 } 153 }
155 154
156 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, 155 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
157 MAYBE_TestBugReportPage) { 156 MAYBE_TestFeedbackPage) {
158 RunBidiCheckerOnPage("chrome://bugreport#0?description=test&issueType=1"); 157 RunBidiCheckerOnPage("chrome://feedback#0?description=test");
159 } 158 }
160 159
161 //============================== 160 //==============================
162 // chrome://crashes 161 // chrome://crashes
163 //============================== 162 //==============================
164 163
165 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestCrashesPage) { 164 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestCrashesPage) {
166 RunBidiCheckerOnPage(chrome::kChromeUICrashesURL); 165 RunBidiCheckerOnPage(chrome::kChromeUICrashesURL);
167 } 166 }
168 167
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 url += std::string(chrome::kSearchEnginesSubPage); 424 url += std::string(chrome::kSearchEnginesSubPage);
426 RunBidiCheckerOnPage(url.c_str()); 425 RunBidiCheckerOnPage(url.c_str());
427 } 426 }
428 427
429 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, 428 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
430 TestSettingsSearchEnginesOptionsPage) { 429 TestSettingsSearchEnginesOptionsPage) {
431 std::string url(chrome::kChromeUISettingsURL); 430 std::string url(chrome::kChromeUISettingsURL);
432 url += std::string(chrome::kSearchEnginesSubPage); 431 url += std::string(chrome::kSearchEnginesSubPage);
433 RunBidiCheckerOnPage(url.c_str()); 432 RunBidiCheckerOnPage(url.c_str());
434 } 433 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/sad_tab_view.cc ('k') | chrome/browser/ui/webui/bug_report_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698