Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 9006003: Refactor and fix feedback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2011 -> 2012 Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
11 11
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 #include "chrome/browser/ui/panels/panel.h" 115 #include "chrome/browser/ui/panels/panel.h"
116 #include "chrome/browser/ui/panels/panel_manager.h" 116 #include "chrome/browser/ui/panels/panel_manager.h"
117 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" 117 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
118 #include "chrome/browser/ui/status_bubble.h" 118 #include "chrome/browser/ui/status_bubble.h"
119 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h" 119 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h"
120 #include "chrome/browser/ui/tab_contents/core_tab_helper.h" 120 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
121 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 121 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
122 #include "chrome/browser/ui/tabs/dock_info.h" 122 #include "chrome/browser/ui/tabs/dock_info.h"
123 #include "chrome/browser/ui/tabs/tab_menu_model.h" 123 #include "chrome/browser/ui/tabs/tab_menu_model.h"
124 #include "chrome/browser/ui/web_applications/web_app_ui.h" 124 #include "chrome/browser/ui/web_applications/web_app_ui.h"
125 #include "chrome/browser/ui/webui/bug_report_ui.h"
126 #include "chrome/browser/ui/webui/chrome_web_ui.h" 125 #include "chrome/browser/ui/webui/chrome_web_ui.h"
126 #include "chrome/browser/ui/webui/feedback_ui.h"
127 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h" 127 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
128 #include "chrome/browser/ui/webui/options/content_settings_handler.h" 128 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
129 #include "chrome/browser/ui/window_sizer.h" 129 #include "chrome/browser/ui/window_sizer.h"
130 #include "chrome/browser/upgrade_detector.h" 130 #include "chrome/browser/upgrade_detector.h"
131 #include "chrome/browser/web_applications/web_app.h" 131 #include "chrome/browser/web_applications/web_app.h"
132 #include "chrome/common/chrome_constants.h" 132 #include "chrome/common/chrome_constants.h"
133 #include "chrome/common/chrome_notification_types.h" 133 #include "chrome/common/chrome_notification_types.h"
134 #include "chrome/common/chrome_switches.h" 134 #include "chrome/common/chrome_switches.h"
135 #include "chrome/common/custom_handlers/protocol_handler.h" 135 #include "chrome/common/custom_handlers/protocol_handler.h"
136 #include "chrome/common/extensions/extension.h" 136 #include "chrome/common/extensions/extension.h"
(...skipping 1959 matching lines...) Expand 10 before | Expand all | Expand 10 after
2096 } 2096 }
2097 2097
2098 void Browser::OpenTaskManager(bool highlight_background_resources) { 2098 void Browser::OpenTaskManager(bool highlight_background_resources) {
2099 content::RecordAction(UserMetricsAction("TaskManager")); 2099 content::RecordAction(UserMetricsAction("TaskManager"));
2100 if (highlight_background_resources) 2100 if (highlight_background_resources)
2101 window_->ShowBackgroundPages(); 2101 window_->ShowBackgroundPages();
2102 else 2102 else
2103 window_->ShowTaskManager(); 2103 window_->ShowTaskManager();
2104 } 2104 }
2105 2105
2106 void Browser::OpenBugReportDialog() { 2106 void Browser::OpenFeedbackDialog() {
2107 content::RecordAction(UserMetricsAction("ReportBug")); 2107 content::RecordAction(UserMetricsAction("Feedback"));
2108 browser::ShowHtmlBugReportView(this, std::string(), 0); 2108 browser::ShowHtmlFeedbackView(this, std::string(), std::string());
2109 } 2109 }
2110 2110
2111 void Browser::ToggleBookmarkBar() { 2111 void Browser::ToggleBookmarkBar() {
2112 content::RecordAction(UserMetricsAction("ShowBookmarksBar")); 2112 content::RecordAction(UserMetricsAction("ShowBookmarksBar"));
2113 window_->ToggleBookmarkBar(); 2113 window_->ToggleBookmarkBar();
2114 } 2114 }
2115 2115
2116 void Browser::OpenBookmarkManager() { 2116 void Browser::OpenBookmarkManager() {
2117 content::RecordAction(UserMetricsAction("ShowBookmarkManager")); 2117 content::RecordAction(UserMetricsAction("ShowBookmarkManager"));
2118 content::RecordAction(UserMetricsAction("ShowBookmarks")); 2118 content::RecordAction(UserMetricsAction("ShowBookmarks"));
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
2173 content::RecordAction(UserMetricsAction("ShowExtensions")); 2173 content::RecordAction(UserMetricsAction("ShowExtensions"));
2174 ShowOptionsTab(chrome::kExtensionsSubPage); 2174 ShowOptionsTab(chrome::kExtensionsSubPage);
2175 } 2175 }
2176 2176
2177 void Browser::ShowAboutConflictsTab() { 2177 void Browser::ShowAboutConflictsTab() {
2178 content::RecordAction(UserMetricsAction("AboutConflicts")); 2178 content::RecordAction(UserMetricsAction("AboutConflicts"));
2179 ShowSingletonTab(GURL(chrome::kChromeUIConflictsURL)); 2179 ShowSingletonTab(GURL(chrome::kChromeUIConflictsURL));
2180 } 2180 }
2181 2181
2182 void Browser::ShowBrokenPageTab(TabContents* contents) { 2182 void Browser::ShowBrokenPageTab(TabContents* contents) {
2183 content::RecordAction(UserMetricsAction("ReportBug")); 2183 content::RecordAction(UserMetricsAction("Feedback"));
2184 string16 page_title = contents->GetTitle(); 2184 string16 page_title = contents->GetTitle();
2185 NavigationEntry* entry = contents->GetController().GetActiveEntry(); 2185 NavigationEntry* entry = contents->GetController().GetActiveEntry();
2186 if (!entry) 2186 if (!entry)
2187 return; 2187 return;
2188 std::string page_url = entry->GetURL().spec(); 2188 std::string page_url = entry->GetURL().spec();
2189 std::vector<std::string> subst; 2189 std::vector<std::string> subst;
2190 subst.push_back(UTF16ToASCII(page_title)); 2190 subst.push_back(UTF16ToASCII(page_title));
2191 subst.push_back(page_url); 2191 subst.push_back(page_url);
2192 std::string report_page_url = 2192 std::string report_page_url =
2193 ReplaceStringPlaceholders(kBrokenPageUrl, subst, NULL); 2193 ReplaceStringPlaceholders(kBrokenPageUrl, subst, NULL);
(...skipping 676 matching lines...) Expand 10 before | Expand all | Expand 10 after
2870 DEVTOOLS_TOGGLE_ACTION_NONE); 2870 DEVTOOLS_TOGGLE_ACTION_NONE);
2871 break; 2871 break;
2872 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow( 2872 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow(
2873 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE); 2873 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
2874 break; 2874 break;
2875 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow( 2875 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow(
2876 DEVTOOLS_TOGGLE_ACTION_INSPECT); 2876 DEVTOOLS_TOGGLE_ACTION_INSPECT);
2877 break; 2877 break;
2878 case IDC_TASK_MANAGER: OpenTaskManager(false); break; 2878 case IDC_TASK_MANAGER: OpenTaskManager(false); break;
2879 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break; 2879 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break;
2880 case IDC_FEEDBACK: OpenBugReportDialog(); break; 2880 case IDC_FEEDBACK: OpenFeedbackDialog(); break;
2881 2881
2882 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break; 2882 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break;
2883 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break; 2883 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break;
2884 2884
2885 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break; 2885 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break;
2886 case IDC_SHOW_APP_MENU: ShowAppMenu(); break; 2886 case IDC_SHOW_APP_MENU: ShowAppMenu(); break;
2887 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break; 2887 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break;
2888 case IDC_SHOW_HISTORY: ShowHistoryTab(); break; 2888 case IDC_SHOW_HISTORY: ShowHistoryTab(); break;
2889 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break; 2889 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break;
2890 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break; 2890 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break;
(...skipping 2500 matching lines...) Expand 10 before | Expand all | Expand 10 after
5391 window_->GetLocationBar()->ShowFirstRunBubble(bubble_type); 5391 window_->GetLocationBar()->ShowFirstRunBubble(bubble_type);
5392 } else { 5392 } else {
5393 GlobalErrorService* service = 5393 GlobalErrorService* service =
5394 GlobalErrorServiceFactory::GetForProfile(profile()); 5394 GlobalErrorServiceFactory::GetForProfile(profile());
5395 GlobalError* error = service->GetFirstGlobalErrorWithBubbleView(); 5395 GlobalError* error = service->GetFirstGlobalErrorWithBubbleView();
5396 if (error) { 5396 if (error) {
5397 error->ShowBubbleView(this); 5397 error->ShowBubbleView(this);
5398 } 5398 }
5399 } 5399 }
5400 } 5400 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698