Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/feedback.html

Issue 9006003: Refactor and fix feedback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes + test fix. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« chrome/browser/resources/feedback.css ('K') | « chrome/browser/resources/feedback.css ('k') | chrome/browser/resources/feedback.js » ('j') | chrome/browser/ui/webui/feedback_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection;"> 2 <html i18n-values="dir:textdirection;">
3 <head> 3 <head>
4 <meta charset="utf-8"/> 4 <meta charset="utf-8"/>
5 <title i18n-content="page-title"></title> 5 <title i18n-content="page-title"></title>
6 <!-- We want to keep our style in sync with the options page. --> 6 <!-- We want to keep our style in sync with the options page. -->
7 <link rel="stylesheet" href="chrome://resources/css/button.css"> 7 <link rel="stylesheet" href="chrome://resources/css/button.css">
8 <link rel="stylesheet" href="chrome://resources/css/checkbox.css"> 8 <link rel="stylesheet" href="chrome://resources/css/checkbox.css">
9 <link rel="stylesheet" href="chrome://resources/css/select.css"> 9 <link rel="stylesheet" href="chrome://resources/css/select.css">
10 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 10 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
11 <link rel="stylesheet" href="bug_report.css"> 11 <link rel="stylesheet" href="feedback.css">
12 12
13 <script src="chrome://resources/js/local_strings.js"></script> 13 <script src="chrome://resources/js/local_strings.js"></script>
14 <script src="chrome://resources/js/util.js"></script> 14 <script src="chrome://resources/js/util.js"></script>
15 <script src="chrome://bugreport/bug_report.js"></script> 15 <script src="chrome://feedback/feedback.js"></script>
16 <script src="chrome://bugreport/strings.js"></script> 16 <script src="chrome://feedback/strings.js"></script>
17 </head> 17 </head>
18 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 18 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
19 <div id="main-content"> 19 <div id="main-content">
20 <div id="navbar-container"> 20 <div id="navbar-container">
21 <h1 id="navbar-content-title" i18n-content="page-title"> 21 <h1 id="navbar-content-title" i18n-content="page-title">
22 </h1> 22 </h1>
23 </div> 23 </div>
24 <div id="mainview" class> 24 <div id="mainview" class>
25 <!-- Even though we really don't need these many nested DIV's, we're staying 25 <!-- Even though we really don't need these many nested DIV's, we're staying
26 as close to the settings page layout as possible, re-using all our styles 26 as close to the settings page layout as possible, re-using all our styles
27 from options_page.css --> 27 from options_page.css -->
28 <div id="mainview-content"> 28 <div id="mainview-content">
29 <div id="page-container"> 29 <div id="page-container">
30 <div id="feedback-page" class="page"> 30 <div id="feedback-page" class="page">
31 <h1 i18n-content="title"></h1> 31 <h1 i18n-content="title"></h1>
32 <table id="main-table"> 32 <table id="main-table">
33 <!-- Issue type dropdown --> 33 <!-- Description -->
34 <tbody>
35 <tr> 34 <tr>
36 <th id="issue-with" class="bug-report-label" 35 <th id="description" colspan="2" class="feedback-label"
37 i18n-content="issue-with"></th>
38 </tr>
39 <tr>
40 <td>
41 <select id="issue-with-combo" class="bug-report-text">
42 </select>
43 </td>
44 </tr>
45 <!-- Description -->
46 <tr>
47 <th id="description" colspan="2" class="bug-report-label"
48 i18n-content="description"></th> 36 i18n-content="description"></th>
49 </tr> 37 </tr>
50 <tr> 38 <tr>
51 <td colspan="2"> 39 <td colspan="2">
52 <textarea id="description-text" rows="10" 40 <textarea id="description-text" rows="10"
53 class="bug-report-text"></textarea> 41 class="feedback-text"></textarea>
54 </td> 42 </td>
55 </tr> 43 </tr>
56 <tr> 44 <tr>
57 <td> 45 <td>
58 <table style="-webkit-border-vertical-spacing: 0px;"> 46 <table style="-webkit-border-vertical-spacing: 0px;">
59 <!-- Page URL --> 47 <!-- Page URL -->
60 <tr> 48 <tr>
61 <td> 49 <td>
62 <table class="bug-report-table"> 50 <table class="feedback-table">
63 <tr> 51 <tr>
64 <td class="bug-report-fieldlabel"> 52 <td class="feedback-fieldlabel">
65 <label> 53 <label>
66 <input id="page-url-checkbox" type="checkbox" 54 <input id="page-url-checkbox" type="checkbox"
67 value="pageurl" checked> 55 value="pageurl" checked>
68 <span id="page-url-label" 56 <span id="page-url-label"
69 i18n-content="page-url"></span> 57 i18n-content="page-url"></span>
70 </label> 58 </label>
71 </td> 59 </td>
72 <td> 60 <td>
73 <input id="page-url-text" class="bug-report-field" 61 <input id="page-url-text" class="feedback-field"
74 maxlength="200"> 62 maxlength="200">
75 </td> 63 </td>
76 </tr> 64 </tr>
77 </table> 65 </table>
78 </td> 66 </td>
79 </tr> 67 </tr>
80 <if expr="pp_ifdef('chromeos')"> 68 <if expr="pp_ifdef('chromeos')">
81 <!-- User e-mail --> 69 <!-- User e-mail -->
82 <tr> 70 <tr>
83 <td> 71 <td>
84 <table id="user-email-table" class="bug-report-table"> 72 <table id="user-email-table" class="feedback-table">
85 <tr> 73 <tr>
86 <td class="bug-report-fieldlabel"> 74 <td class="feedback-fieldlabel">
87 <label> 75 <label>
88 <input id="user-email-checkbox" type="checkbox" 76 <input id="user-email-checkbox" type="checkbox"
89 checked> 77 checked>
90 <span id="user-email-label" 78 <span id="user-email-label"
91 i18n-content="user-email"></span> 79 i18n-content="user-email"></span>
92 </label> 80 </label>
93 </td> 81 </td>
94 <td> 82 <td>
95 <label id="user-email-text" 83 <label id="user-email-text"
96 class="bug-report-field"></label> 84 class="feedback-field"></label>
97 </td> 85 </td>
98 </tr> 86 </tr>
99 </table> 87 </table>
100 </td> 88 </td>
101 </tr> 89 </tr>
102 <!-- System Information --> 90 <!-- System Information -->
103 <tr> 91 <tr>
104 <td> 92 <td>
105 <table class="bug-report-table"> 93 <table class="feedback-table">
106 <tr> 94 <tr>
107 <td class="bug-report-fieldlabel"> 95 <td class="feedback-fieldlabel">
108 <label> 96 <label>
109 <input id="sys-info-checkbox" type="checkbox" 97 <input id="sys-info-checkbox" type="checkbox"
110 checked> 98 checked>
111 <span id="sysinfo-label"> 99 <span id="sysinfo-label">
112 <a id="sysinfo-url" href="#" 100 <a id="sysinfo-url" href="#"
113 i18n-content="sysinfo"></a> 101 i18n-content="sysinfo"></a>
114 </span> 102 </span>
115 </label> 103 </label>
116 </td> 104 </td>
117 </tr> 105 </tr>
118 </table> 106 </table>
119 </td> 107 </td>
120 </tr> 108 </tr>
121 </if> 109 </if>
122 <!-- Screenshot --> 110 <!-- Screenshot -->
123 <tr> 111 <tr>
124 <td> 112 <td>
125 <table class="bug-report-table"> 113 <table class="feedback-table">
126 <tr> 114 <tr>
127 <td class="bug-report-fieldlabel"> 115 <td class="feedback-fieldlabel">
128 <label> 116 <label>
129 <input id="screenshot-checkbox" type="checkbox"> 117 <input id="screenshot-checkbox" type="checkbox">
130 <span id="screenshot-label-current" 118 <span id="screenshot-label-current"
131 i18n-content="current-screenshot"></span> 119 i18n-content="current-screenshot"></span>
132 </label> 120 </label>
133 <if expr="pp_ifdef('chromeos')"> 121 <if expr="pp_ifdef('chromeos')">
134 <span id="screenshot-label-saved" 122 <span id="screenshot-label-saved"
135 style="display: none;" 123 style="display: none;"
136 i18n-content="saved-screenshot"> 124 i18n-content="saved-screenshot">
137 </span> 125 </span>
(...skipping 18 matching lines...) Expand all
156 </if> 144 </if>
157 <div id="current-screenshots" class="thumbnail-list"> 145 <div id="current-screenshots" class="thumbnail-list">
158 </div> 146 </div>
159 </td> 147 </td>
160 </tr> 148 </tr>
161 </table> 149 </table>
162 </td> 150 </td>
163 </tr> 151 </tr>
164 <tr> 152 <tr>
165 <td> 153 <td>
154 <div id="privacy-note" i18n-values=".innerHTML:privacy-note">
155 </div>
166 <div id="buttons-pane"> 156 <div id="buttons-pane">
167 <!-- Buttons --> 157 <!-- Buttons -->
168 <input id="send-report-button" type="submit" 158 <input id="send-report-button" type="submit"
169 class="bug-report-button" 159 class="feedback-button"
170 i18n-values="value:send-report"> 160 i18n-values="value:send-report">
171 <input id="cancel-button" type="submit" 161 <input id="cancel-button" type="submit"
172 class="bug-report-button" i18n-values="value:cancel"> 162 class="feedback-button" i18n-values="value:cancel">
173 </div>
174 <div id="privacy-note" i18n-values=".innerHTML:privacy-note">
175 </div> 163 </div>
176 </td> 164 </td>
177 </tr> 165 </tr>
178 </tbody> 166 </tbody>
179 </table> 167 </table>
180 </div> 168 </div>
181 </div> 169 </div>
182 </div> 170 </div>
183 </div> 171 </div>
184 </div> 172 </div>
185 <script src="chrome://resources/js/i18n_template.js"></script> 173 <script src="chrome://resources/js/i18n_template.js"></script>
186 <script src="chrome://resources/js/i18n_process.js"></script> 174 <script src="chrome://resources/js/i18n_process.js"></script>
187 </body> 175 </body>
188 </html> 176 </html>
OLDNEW
« chrome/browser/resources/feedback.css ('K') | « chrome/browser/resources/feedback.css ('k') | chrome/browser/resources/feedback.js » ('j') | chrome/browser/ui/webui/feedback_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698