Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 9006003: Refactor and fix feedback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 #include "chrome/browser/ui/panels/panel.h" 114 #include "chrome/browser/ui/panels/panel.h"
115 #include "chrome/browser/ui/panels/panel_manager.h" 115 #include "chrome/browser/ui/panels/panel_manager.h"
116 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" 116 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
117 #include "chrome/browser/ui/status_bubble.h" 117 #include "chrome/browser/ui/status_bubble.h"
118 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h" 118 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h"
119 #include "chrome/browser/ui/tab_contents/core_tab_helper.h" 119 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
120 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 120 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
121 #include "chrome/browser/ui/tabs/dock_info.h" 121 #include "chrome/browser/ui/tabs/dock_info.h"
122 #include "chrome/browser/ui/tabs/tab_menu_model.h" 122 #include "chrome/browser/ui/tabs/tab_menu_model.h"
123 #include "chrome/browser/ui/web_applications/web_app_ui.h" 123 #include "chrome/browser/ui/web_applications/web_app_ui.h"
124 #include "chrome/browser/ui/webui/bug_report_ui.h"
125 #include "chrome/browser/ui/webui/chrome_web_ui.h" 124 #include "chrome/browser/ui/webui/chrome_web_ui.h"
125 #include "chrome/browser/ui/webui/feedback_ui.h"
126 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h" 126 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
127 #include "chrome/browser/ui/webui/options/content_settings_handler.h" 127 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
128 #include "chrome/browser/ui/window_sizer.h" 128 #include "chrome/browser/ui/window_sizer.h"
129 #include "chrome/browser/upgrade_detector.h" 129 #include "chrome/browser/upgrade_detector.h"
130 #include "chrome/browser/web_applications/web_app.h" 130 #include "chrome/browser/web_applications/web_app.h"
131 #include "chrome/common/chrome_constants.h" 131 #include "chrome/common/chrome_constants.h"
132 #include "chrome/common/chrome_notification_types.h" 132 #include "chrome/common/chrome_notification_types.h"
133 #include "chrome/common/chrome_switches.h" 133 #include "chrome/common/chrome_switches.h"
134 #include "chrome/common/custom_handlers/protocol_handler.h" 134 #include "chrome/common/custom_handlers/protocol_handler.h"
135 #include "chrome/common/extensions/extension.h" 135 #include "chrome/common/extensions/extension.h"
(...skipping 1944 matching lines...) Expand 10 before | Expand all | Expand 10 after
2080 } 2080 }
2081 2081
2082 void Browser::OpenTaskManager(bool highlight_background_resources) { 2082 void Browser::OpenTaskManager(bool highlight_background_resources) {
2083 content::RecordAction(UserMetricsAction("TaskManager")); 2083 content::RecordAction(UserMetricsAction("TaskManager"));
2084 if (highlight_background_resources) 2084 if (highlight_background_resources)
2085 window_->ShowBackgroundPages(); 2085 window_->ShowBackgroundPages();
2086 else 2086 else
2087 window_->ShowTaskManager(); 2087 window_->ShowTaskManager();
2088 } 2088 }
2089 2089
2090 void Browser::OpenBugReportDialog() { 2090 void Browser::OpenFeedbackDialog() {
2091 content::RecordAction(UserMetricsAction("ReportBug")); 2091 content::RecordAction(UserMetricsAction("Feedback"));
2092 browser::ShowHtmlBugReportView(this, std::string(), 0); 2092 browser::ShowHtmlFeedbackView(this, std::string(), std::string());
2093 } 2093 }
2094 2094
2095 void Browser::ToggleBookmarkBar() { 2095 void Browser::ToggleBookmarkBar() {
2096 content::RecordAction(UserMetricsAction("ShowBookmarksBar")); 2096 content::RecordAction(UserMetricsAction("ShowBookmarksBar"));
2097 window_->ToggleBookmarkBar(); 2097 window_->ToggleBookmarkBar();
2098 } 2098 }
2099 2099
2100 void Browser::OpenBookmarkManager() { 2100 void Browser::OpenBookmarkManager() {
2101 content::RecordAction(UserMetricsAction("ShowBookmarkManager")); 2101 content::RecordAction(UserMetricsAction("ShowBookmarkManager"));
2102 content::RecordAction(UserMetricsAction("ShowBookmarks")); 2102 content::RecordAction(UserMetricsAction("ShowBookmarks"));
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
2157 content::RecordAction(UserMetricsAction("ShowExtensions")); 2157 content::RecordAction(UserMetricsAction("ShowExtensions"));
2158 ShowOptionsTab(chrome::kExtensionsSubPage); 2158 ShowOptionsTab(chrome::kExtensionsSubPage);
2159 } 2159 }
2160 2160
2161 void Browser::ShowAboutConflictsTab() { 2161 void Browser::ShowAboutConflictsTab() {
2162 content::RecordAction(UserMetricsAction("AboutConflicts")); 2162 content::RecordAction(UserMetricsAction("AboutConflicts"));
2163 ShowSingletonTab(GURL(chrome::kChromeUIConflictsURL)); 2163 ShowSingletonTab(GURL(chrome::kChromeUIConflictsURL));
2164 } 2164 }
2165 2165
2166 void Browser::ShowBrokenPageTab(TabContents* contents) { 2166 void Browser::ShowBrokenPageTab(TabContents* contents) {
2167 content::RecordAction(UserMetricsAction("ReportBug")); 2167 content::RecordAction(UserMetricsAction("Feedback"));
2168 string16 page_title = contents->GetTitle(); 2168 string16 page_title = contents->GetTitle();
2169 NavigationEntry* entry = contents->controller().GetActiveEntry(); 2169 NavigationEntry* entry = contents->controller().GetActiveEntry();
2170 if (!entry) 2170 if (!entry)
2171 return; 2171 return;
2172 std::string page_url = entry->url().spec(); 2172 std::string page_url = entry->url().spec();
2173 std::vector<std::string> subst; 2173 std::vector<std::string> subst;
2174 subst.push_back(UTF16ToASCII(page_title)); 2174 subst.push_back(UTF16ToASCII(page_title));
2175 subst.push_back(page_url); 2175 subst.push_back(page_url);
2176 std::string report_page_url = 2176 std::string report_page_url =
2177 ReplaceStringPlaceholders(kBrokenPageUrl, subst, NULL); 2177 ReplaceStringPlaceholders(kBrokenPageUrl, subst, NULL);
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
2851 DEVTOOLS_TOGGLE_ACTION_NONE); 2851 DEVTOOLS_TOGGLE_ACTION_NONE);
2852 break; 2852 break;
2853 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow( 2853 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow(
2854 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE); 2854 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
2855 break; 2855 break;
2856 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow( 2856 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow(
2857 DEVTOOLS_TOGGLE_ACTION_INSPECT); 2857 DEVTOOLS_TOGGLE_ACTION_INSPECT);
2858 break; 2858 break;
2859 case IDC_TASK_MANAGER: OpenTaskManager(false); break; 2859 case IDC_TASK_MANAGER: OpenTaskManager(false); break;
2860 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break; 2860 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break;
2861 case IDC_FEEDBACK: OpenBugReportDialog(); break; 2861 case IDC_FEEDBACK: OpenFeedbackDialog(); break;
2862 2862
2863 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break; 2863 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break;
2864 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break; 2864 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break;
2865 2865
2866 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break; 2866 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break;
2867 case IDC_SHOW_APP_MENU: ShowAppMenu(); break; 2867 case IDC_SHOW_APP_MENU: ShowAppMenu(); break;
2868 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break; 2868 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break;
2869 case IDC_SHOW_HISTORY: ShowHistoryTab(); break; 2869 case IDC_SHOW_HISTORY: ShowHistoryTab(); break;
2870 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break; 2870 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break;
2871 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break; 2871 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break;
(...skipping 2476 matching lines...) Expand 10 before | Expand all | Expand 10 after
5348 window_->GetLocationBar()->ShowFirstRunBubble(bubble_type); 5348 window_->GetLocationBar()->ShowFirstRunBubble(bubble_type);
5349 } else { 5349 } else {
5350 GlobalErrorService* service = 5350 GlobalErrorService* service =
5351 GlobalErrorServiceFactory::GetForProfile(profile()); 5351 GlobalErrorServiceFactory::GetForProfile(profile());
5352 GlobalError* error = service->GetFirstGlobalErrorWithBubbleView(); 5352 GlobalError* error = service->GetFirstGlobalErrorWithBubbleView();
5353 if (error) { 5353 if (error) {
5354 error->ShowBubbleView(this); 5354 error->ShowBubbleView(this);
5355 } 5355 }
5356 } 5356 }
5357 } 5357 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698