Issue 9004052: GetPlatformFileInfo was always never returning directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9004052: GetPlatformFileInfo was always never returning directory (Closed)

Created:
8 years, 12 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

GetPlatformFileInfo was always never returning directory - Because relational operators have higher precedence than bitwise operators BUG=none TEST=unittest included

Patch Set 1 #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	base/file_util_unittest.cc	View		2 chunks	+19 lines, -1 line	0 comments	Download
	M	base/platform_file_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/9004052/1

8 years, 12 months ago (2011-12-29 20:08:39 UTC) #3

Change committed as 115998

Expand Messages | Collapse Messages