Replace MessageLoop::DeleteSoon implementation with one that uses base::Bind.

Replace MessageLoop::DeleteSoon implementation with one that uses base::Bind.

BUG=none
TEST=none
TBR=willchan,brettw,tony

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115997

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116026

[dcheng, 2011-12-28 23:17:41]

Using the elegant reinterpret_cast<> trick you suggested =)

make all is still running locally, so I'll update this CL with any fixups. I'll
be landing it through the trybots and TBRing approvers.

[awong, 2011-12-28 23:24:19]

Heh...it's only elegant if you can stand the reinterpret_cast :P.

Got one comment.

http://codereview.chromium.org/9004051/diff/1/base/message_loop.h
File base/message_loop.h (right):

http://codereview.chromium.org/9004051/diff/1/base/message_loop.h#newcode48
base/message_loop.h:48: template <class T>
This needs a comment explaining why we need this.

Basically, we need a template helper to "erase" T from the signature, while
still remembering it for use with deleting a pointer.  Embedding this in a class
makes it easier for users of DeleteSoon, etc., to declare this as a friend. And
lastly, no one but MessageLoop should call DoDelete.

BTW, is it worth making DoDelete() private and friending MessageLoop?

[dcheng, 2011-12-28 23:34:19]

http://codereview.chromium.org/9004051/diff/1/base/message_loop.h
File base/message_loop.h (right):

http://codereview.chromium.org/9004051/diff/1/base/message_loop.h#newcode48
base/message_loop.h:48: template <class T>
On 2011/12/28 23:24:19, awong wrote:
> This needs a comment explaining why we need this.
> 
> Basically, we need a template helper to "erase" T from the signature, while
> still remembering it for use with deleting a pointer.  Embedding this in a
class
> makes it easier for users of DeleteSoon, etc., to declare this as a friend.
And
> lastly, no one but MessageLoop should call DoDelete.
> 
> BTW, is it worth making DoDelete() private and friending MessageLoop?

Done. As discussed, made DoDelete private as well since all locations that
directly use DeleteTask will be converted to use DeleteSoon.

[awong, 2011-12-28 23:36:55]

LGTM

[commit-bot: I haz the power, 2011-12-28 23:43:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/9004051/4001

[commit-bot: I haz the power, 2011-12-28 23:59:58]

Try job failure for 9004051-4001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[dcheng, 2011-12-29 01:57:07]

Let me know what you think of the new helper + comments.

I'm doing a clean build locally to fix up the rest of the compile errors in the
mean time.

[awong, 2011-12-29 18:09:11]

LGTM

http://codereview.chromium.org/9004051/diff/12001/base/message_loop_helpers.h
File base/message_loop_helpers.h (right):

http://codereview.chromium.org/9004051/diff/12001/base/message_loop_helpers.h...
base/message_loop_helpers.h:15: namespace base {
Add a newline here.

[commit-bot: I haz the power, 2011-12-29 18:15:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/9004051/12002

[commit-bot: I haz the power, 2011-12-29 22:40:41]

Try job failure for 9004051-12002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...