Move signaling connection creation out of ChromotingHost.

remoting/host/register_support_host_request_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/register_support_host_request.h"
 
+#include <list>
+
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
 #include "remoting/base/constants.h"
 #include "remoting/host/host_key_pair.h"
 #include "remoting/host/in_memory_host_config.h"
 #include "remoting/host/test_key_pair.h"
 #include "remoting/jingle_glue/iq_sender.h"
 #include "remoting/jingle_glue/mock_objects.h"
@@ skipping 35 matching lines @@
     config_ = new InMemoryHostConfig();
     config_->SetString(kPrivateKeyConfigPath, kTestHostKeyPair);
   }
 
   MockSignalStrategy signal_strategy_;
   MessageLoop message_loop_;
   scoped_refptr<InMemoryHostConfig> config_;
   MockCallback callback_;
 };
 
+ACTION_P(SaveListener, list) {
+  list->push_back(arg0);
+}
+
 TEST_F(RegisterSupportHostRequestTest, Send) {
   // |iq_request| is freed by RegisterSupportHostRequest.
   int64 start_time = static_cast<int64>(base::Time::Now().ToDoubleT());
 
-  SignalStrategy::Listener* listener;
+  std::list<SignalStrategy::Listener*> listeners;
   EXPECT_CALL(signal_strategy_, AddListener(NotNull()))
-      .WillOnce(SaveArg<0>(&listener));
+      .WillRepeatedly(SaveListener(&listeners));
 
   scoped_ptr<RegisterSupportHostRequest> request(
       new RegisterSupportHostRequest());
   ASSERT_TRUE(request->Init(
-      config_, base::Bind(&MockCallback::OnResponse,
-                          base::Unretained(&callback_))));
+      &signal_strategy_, config_, base::Bind(&MockCallback::OnResponse,
+                                            base::Unretained(&callback_))));
 
   XmlElement* sent_iq = NULL;
   EXPECT_CALL(signal_strategy_, GetNextId())
       .WillOnce(Return(kStanzaId));
   EXPECT_CALL(signal_strategy_, GetLocalJid())
       .WillRepeatedly(Return(kTestJid));
   EXPECT_CALL(signal_strategy_, SendStanza(NotNull()))
       .WillOnce(DoAll(SaveArg<0>(&sent_iq), Return(true)));
 
-  request->OnSignallingConnected(&signal_strategy_);
+  request->OnSignalStrategyStateChange(SignalStrategy::CONNECTED);
   message_loop_.RunAllPending();
 
   // Verify format of the query.
   scoped_ptr<XmlElement> stanza(sent_iq);
   ASSERT_TRUE(stanza != NULL);
 
   EXPECT_EQ(stanza->Attr(buzz::QName("", "to")),
             std::string(kChromotingBotJid));
   EXPECT_EQ(stanza->Attr(buzz::QName("", "type")), "set");
 
@@ skipping 34 matching lines @@
   XmlElement* support_id = new XmlElement(
       QName(kChromotingXmlNamespace, "support-id"));
   support_id->AddText(kSupportId);
   result->AddElement(support_id);
 
   XmlElement* support_id_lifetime = new XmlElement(
       QName(kChromotingXmlNamespace, "support-id-lifetime"));
   support_id_lifetime->AddText(kSupportIdLifetime);
   result->AddElement(support_id_lifetime);
 
-  EXPECT_TRUE(listener->OnSignalStrategyIncomingStanza(response.get()));
+  std::list<SignalStrategy::Listener*>::iterator it;
+  bool consumed = false;
+  for (it = listeners.begin(); it != listeners.end(); it++) {
+    consumed = consumed | (*it)->OnSignalStrategyIncomingStanza(response.get());
+  }
+  EXPECT_TRUE(consumed);
   message_loop_.RunAllPending();
 
-  EXPECT_CALL(signal_strategy_, RemoveListener(listener));
+  EXPECT_CALL(signal_strategy_, RemoveListener(_))
+      .Times(listeners.size());

[Wez, 2012/01/03 16:25:04]

Ick.  Confusing; at what point is |listeners.size()| actually bound for this
expectation?

[Sergey Ulanov, 2012/01/03 21:51:02]

Done.

 }
 
 }  // namespace remoting