Issue 9004033: Rename touchpad_settings.* to input_device_settings.*

Issue 9004033: Rename touchpad_settings.* to input_device_settings.* (Closed)

Created:
9 years ago by achuithb

Modified:
9 years ago

Reviewers:
xiyuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Rename touchpad_settings.* to input_device_settings.* BUG=chromium-os:22305 TEST=compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115199

Patch Set 2 : review feedback #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -148 lines)			Patch
M	chrome/browser/chromeos/preferences.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/chromeos/system/input_device_settings.h	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/system/input_device_settings.cc	View		1 chunk	+111 lines, -0 lines	0 comments	Download
D	chrome/browser/chromeos/system/touchpad_settings.h	View		1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/chromeos/system/touchpad_settings.cc	View		1 chunk	+0 lines, -111 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/system_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/system_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

xiyuan

I did not see the gyp file in CL. Did you forget to include them? ...

9 years ago (2011-12-20 20:30:39 UTC) #2

achuithb

On 2011/12/20 20:30:39, xiyuan wrote: > I did not see the gyp file in CL. ...

9 years ago (2011-12-20 20:36:20 UTC) #3

achuithb

PTAL http://codereview.chromium.org/9004033/diff/1/chrome/browser/chromeos/system/input_device_settings.h File chrome/browser/chromeos/system/input_device_settings.h (right): http://codereview.chromium.org/9004033/diff/1/chrome/browser/chromeos/system/input_device_settings.h#newcode11 chrome/browser/chromeos/system/input_device_settings.h:11: namespace touchpad_settings { On 2011/12/20 20:30:39, xiyuan wrote: ...

9 years ago (2011-12-20 20:36:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/9004033/4001

9 years ago (2011-12-20 20:40:19 UTC) #6

Change committed as 115199

Expand Messages | Collapse Messages