Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 9004032: Issue 895: NPEs in DeltaAnalyser (Closed)

Created:
9 years ago by codefu
Modified:
9 years ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, mmendez
Visibility:
Public.

Description

Issue 895: NPEs in DeltaAnalyser When copying old elements in the DeltaAnalyser, skip the members that don't have nodes. When called with null parameters from the completion engine, just return. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/DeltaAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
codefu
Noticed this didn't send out a review email..
9 years ago (2011-12-22 14:10:36 UTC) #1
danrubel
9 years ago (2011-12-22 14:56:14 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698