Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: webkit/fileapi/sandbox_mount_point_provider.h

Issue 9004019: Cleanup: Removing FileSystemPathManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/quota_file_util_unittest.cc ('k') | webkit/fileapi/sandbox_mount_point_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/sandbox_mount_point_provider.h
diff --git a/webkit/fileapi/sandbox_mount_point_provider.h b/webkit/fileapi/sandbox_mount_point_provider.h
index 5fa76ab2b698b052e9d26ab531ca2e0b0026abfe..dc2bcb1bc015c3f7653c9e7e456adeffe3ad7c6c 100644
--- a/webkit/fileapi/sandbox_mount_point_provider.h
+++ b/webkit/fileapi/sandbox_mount_point_provider.h
@@ -13,6 +13,7 @@
#include "base/memory/scoped_ptr.h"
#include "googleurl/src/gurl.h"
#include "webkit/fileapi/file_system_mount_point_provider.h"
+#include "webkit/fileapi/file_system_options.h"
#include "webkit/fileapi/file_system_quota_util.h"
namespace base {
@@ -36,6 +37,8 @@ class SandboxMountPointProvider
: public FileSystemMountPointProvider,
public FileSystemQuotaUtil {
public:
+ typedef FileSystemMountPointProvider::GetRootPathCallback GetRootPathCallback;
+
// Origin enumerator interface.
// An instance of this interface is assumed to be called on the file thread.
class OriginEnumerator {
@@ -58,9 +61,9 @@ class SandboxMountPointProvider
static const FilePath::CharType kRenamedOldFileSystemDirectory[];
SandboxMountPointProvider(
- FileSystemPathManager* path_manager,
scoped_refptr<base::MessageLoopProxy> file_message_loop,
- const FilePath& profile_path);
+ const FilePath& profile_path,
+ const FileSystemOptions& file_system_options);
virtual ~SandboxMountPointProvider();
// FileSystemMountPointProvider overrides.
@@ -72,7 +75,7 @@ class SandboxMountPointProvider
const GURL& origin_url,
FileSystemType type,
bool create,
- const FileSystemPathManager::GetRootPathCallback& callback) OVERRIDE;
+ const GetRootPathCallback& callback) OVERRIDE;
virtual FilePath ValidateFileSystemRootAndGetPathOnFileThread(
const GURL& origin_url,
FileSystemType type,
@@ -148,20 +151,22 @@ class SandboxMountPointProvider
FilePath OldCreateFileSystemRootPath(
const GURL& origin_url, FileSystemType type);
+ // Returns true if the given |url|'s scheme is allowed to access
+ // filesystem.
+ bool IsAllowedScheme(const GURL& url) const;
+
class GetFileSystemRootPathTask;
friend class FileSystemTestOriginHelper;
friend class SandboxMountPointProviderMigrationTest;
friend class SandboxMountPointProviderOriginEnumeratorTest;
- // The path_manager_ isn't owned by this instance; this instance is owned by
- // the path_manager_, and they have the same lifetime.
- FileSystemPathManager* path_manager_;
-
scoped_refptr<base::MessageLoopProxy> file_message_loop_;
const FilePath profile_path_;
+ FileSystemOptions file_system_options_;
+
scoped_refptr<ObfuscatedFileUtil> sandbox_file_util_;
// Acccessed only on the file thread.
« no previous file with comments | « webkit/fileapi/quota_file_util_unittest.cc ('k') | webkit/fileapi/sandbox_mount_point_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698