Issue 9003015: Extend sign bit before serializing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9003015: Extend sign bit before serializing it. (Closed)

Created:
8 years, 11 months ago by Anton Muhin

Modified:
8 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Extend sign bit before serializing it.

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/snapshot.h	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	runtime/vm/snapshot.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 11 months ago (2012-01-03 22:55:17 UTC) #1

http://codereview.chromium.org/9003015/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

http://codereview.chromium.org/9003015/diff/1/runtime/vm/snapshot.cc#newcode260
runtime/vm/snapshot.cc:260:
WriteIntptrValue(reinterpret_cast<intptr_t>(rawobj));
Can we make this:
Write<int64_t>(reinterpret_cast<intptr_t>(rawobj));

http://codereview.chromium.org/9003015/diff/1/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

http://codereview.chromium.org/9003015/diff/1/runtime/vm/snapshot.h#newcode358
runtime/vm/snapshot.h:358: Write<int64_t>(static_cast<int64_t>(value));
Is this cast necessary, isn't there an implicit cast from intptr_t to int64_t?

Expand Messages | Collapse Messages