Issue 9003013: Remove some wstrings in test_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9003013: Remove some wstrings in test_shell. (Closed)

Created:
8 years, 12 months ago by tony

Modified:
8 years, 11 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove some wstrings in test_shell. Turns out we never used the title so we can remove it completely. BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116173

Patch Set 1 #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -25 lines)			Patch
M	webkit/tools/test_shell/test_navigation_controller.h	View	5 chunks	+4 lines, -9 lines	0 comments	Download
M	webkit/tools/test_shell/test_navigation_controller.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/9003013/1

8 years, 11 months ago (2012-01-03 18:47:22 UTC) #3

commit-bot: I haz the power

8 years, 11 months ago (2012-01-03 18:47:26 UTC) #4

Presubmit check for 9003013-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  webkit/tools/test_shell/test_shell.h

Presubmit checks took 1.0s to calculate.

Expand Messages | Collapse Messages