Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 90006: Put $_LIBDIRFLAGS before ${LINK,SHLINK,LDMODULE}FLAGS so we prefer... (Closed)

Created:
11 years, 8 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
evanm, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Put $_LIBDIRFLAGS before ${LINK,SHLINK,LDMODULE}FLAGS so we prefer our own libs (libpng.a, libz.a, etc.) to system ones. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
For himikof's problem earlier today.
11 years, 8 months ago (2009-04-20 20:49:26 UTC) #1
Evan Martin
11 years, 8 months ago (2009-04-20 20:51:35 UTC) #2
LGTM

Thanks for tracking it down!

Powered by Google App Engine
This is Rietveld 408576698