Issue 90003: Make it possible to add a user data object to each script compiled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90003: Make it possible to add a user data object to each script compiled (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make it possible to add a user data object to each script compiled. Committed: http://code.google.com/p/v8/source/detail?r=1748

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -2 lines)			Patch
M	include/v8.h	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	src/accessors.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/accessors.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/api.cc	View		2 chunks	+29 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/debug-delay.js	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mirror-delay.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	src/objects-inl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View		4 chunks	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

The main motivation for this change to to make it possible for Chrome to add ...

11 years, 8 months ago (2009-04-20 20:34:52 UTC) #1

Mads Ager (chromium)

11 years, 8 months ago (2009-04-21 05:33:26 UTC) #2

LGTM

http://codereview.chromium.org/90003/diff/1/4
File include/v8.h (right):

http://codereview.chromium.org/90003/diff/1/4#newcode551
Line 551: * Returns the resource name for the script from where the function
causeing
causing

http://codereview.chromium.org/90003/diff/1/4#newcode557
Line 557: * Returns the resource data for the script from where the function
causeing
causing

http://codereview.chromium.org/90003/diff/1/7
File src/accessors.h (right):

http://codereview.chromium.org/90003/diff/1/7#newcode48
Line 48: V(ScriptData)  \
Right align the '\'.

http://codereview.chromium.org/90003/diff/1/8
File src/objects.h (right):

http://codereview.chromium.org/90003/diff/1/8#newcode2606
Line 2606: // [data]: additional data passed when compiling this script.
additional data associated with this script?

The data is not really passed in when compiling the script - it is set after the
script object has been created.

Expand Messages | Collapse Messages