Issue 900001: r41078 broke revinfo for .gclient files with multiple solutions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 900001: r41078 broke revinfo for .gclient files with multiple solutions (Closed)

Created:
10 years, 9 months ago by Nasser Grainawi

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, jneddo1

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

r41078 broke revinfo for .gclient files with multiple solutions This commit fixes that, though the --snapshot option doesn't work perfectly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41351

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -44 lines)			Patch
	M	gclient.py	View		2 chunks	+47 lines, -44 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/900001/diff/1/2 File gclient.py (right): http://codereview.chromium.org/900001/diff/1/2#newcode876 gclient.py:876: # DEBUG Remove this please.

10 years, 9 months ago (2010-03-11 23:46:06 UTC) #2

Nasser Grainawi

10 years, 9 months ago (2010-03-11 23:47:21 UTC) #3

On 2010/03/11 23:46:06, Marc-Antoine Ruel wrote:
> lgtm
> 
> http://codereview.chromium.org/900001/diff/1/2
> File gclient.py (right):
> 
> http://codereview.chromium.org/900001/diff/1/2#newcode876
> gclient.py:876: # DEBUG
> Remove this please.

Doh. I'll commit with the fixes.

Expand Messages | Collapse Messages