Make incognito windows not inherit HSTS state from the main profile.

chrome/browser/profiles/profile_io_data.cc

Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index f853438a477139e7a06b2daefe83ded09791ff93..673bdc2445f5f8f0d3ded2269a398b789f54df2d 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -34,7 +34,6 @@
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
-#include "chrome/browser/transport_security_persister.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager_backend.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
@@ -443,13 +442,6 @@ void ProfileIOData::LazyInitialize() const {
           profile_params_->proxy_config_service.release(),
           command_line));
 
-  transport_security_state_.reset(new net::TransportSecurityState(
-      command_line.GetSwitchValueASCII(switches::kHstsHosts)));

[wtc, 2012/01/04 23:51:28]

It may be a good idea to explain here or in the header file
that transport_security_state_ is initialized by a derived
class.

It seems that we can still initialize transport_security_state_
here in the base class, because the two derived classes
would be initializing it the same way (from the command
line option).  We just need to move transport_security_persister_
to ProfileImplIOData.  transport_security_state_ can remain
a private member of the base class.  ProfileImplIOData can
access it using the transport_security_state() getter.

Will that work?

-  transport_security_persister_.reset(
-      new TransportSecurityPersister(transport_security_state_.get(),
-                                     profile_params_->path,
-                                     profile_params_->is_incognito));
-
   // NOTE(willchan): Keep these protocol handlers in sync with
   // ProfileIOData::IsHandledProtocol().
   job_factory_.reset(new net::URLRequestJobFactory);