Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8997008: Move AccessTokenStore to Content API, now that it is a pure-virtual class. (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move AccessTokenStore to Content API, now that it is a pure-virtual class. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115335

Patch Set 1 #

Patch Set 2 : Merge to LKGR (pure merge). #

Patch Set 3 : Merge to head (pure merge). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -98 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/geolocation/access_token_store_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
D content/browser/geolocation/access_token_store.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D content/browser/geolocation/access_token_store.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factories_for_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factories_for_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factory.h View 4 chunks +8 lines, -5 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/geolocation/fake_access_token_store.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/geolocation/fake_access_token_store.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/geolocation/location_arbitrator.h View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/geolocation/location_arbitrator.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/geolocation/location_provider.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/browser/access_token_store.h View 3 chunks +7 lines, -3 lines 0 comments Download
A + content/public/browser/access_token_store.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jói
As before, there are matching deletes for the A+ files in my client, not sure ...
9 years ago (2011-12-19 14:28:43 UTC) #1
jam
lgtm
9 years ago (2011-12-19 15:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8997008/7003
9 years ago (2011-12-21 13:53:53 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-21 15:04:50 UTC) #4 
Change committed as 115335

Powered by Google App Engine
This is Rietveld 408576698