Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 8996024: Fix a bug in intrinsified Array_setIndexed type check. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/opt_code_generator_ia32.h » ('j') | runtime/vm/opt_code_generator_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
===================================================================
--- runtime/vm/intrinsifier_ia32.cc (revision 2600)
+++ runtime/vm/intrinsifier_ia32.cc (working copy)
@@ -199,7 +199,7 @@
__ movl(EAX, Address(ESP, + 1 * kWordSize)); // Value.
__ movl(EBX, Address(ESP, + 2 * kWordSize)); // Index.
__ orl(EAX, EBX);
- __ testl(EBX, Immediate(kSmiTagMask));
+ __ testl(EAX, Immediate(kSmiTagMask));
siva 2011/12/20 01:38:00 Is there a unit test which exposes this bug and va
srdjan 2011/12/20 02:06:33 It is difficult to test, since the only thing it d
// Value or index not Smi.
__ j(NOT_ZERO, &fall_through, Assembler::kNearJump);
__ movl(EAX, Address(ESP, + 3 * kWordSize)); // Array.
« no previous file with comments | « no previous file | runtime/vm/opt_code_generator_ia32.h » ('j') | runtime/vm/opt_code_generator_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698