[depot_tools] Disabling new git checkouts with safesync_urls until fixed.

gclient.py

Index: gclient.py
diff --git a/gclient.py b/gclient.py
index c804186e858dc56b9d018008ceb742a5a93eb9c0..d90e05967b108b28ac8fb30af92b809f79c51382 100644
--- a/gclient.py
+++ b/gclient.py
@@ -920,18 +920,7 @@ solutions = [
         if not s.managed:
           self._options.revisions.append('%s@unmanaged' % s.name)
         elif s.safesync_url:
-          handle = urllib.urlopen(s.safesync_url)
-          rev = handle.read().strip()
-          handle.close()
-          scm = gclient_scm.CreateSCM(s.url, s.root.root_dir, s.name)
-          safe_rev = scm.GetUsableRev(rev=rev, options=self._options)
-          if not safe_rev:
-            raise gclient_utils.Error(
-                'Despite our best attempts, we couldn\'t find a useful\n'
-                'safesync_url revision for you.')
-          if self._options.verbose:
-            print('Using safesync_url revision: %s.\n' % safe_rev)
-          self._options.revisions.append('%s@%s' % (s.name, safe_rev))
+          self._ApplySafeSyncRev(dep=s)
     if not self._options.revisions:
       return revision_overrides
     solutions_names = [s.name for s in self.dependencies]
@@ -950,6 +939,25 @@ solutions = [
       index += 1
     return revision_overrides
 
+  def _ApplySafeSyncRev(self, dep):
+    """Finds a valid revision from the content of the safesync_url and apply it
+    by appending revisions to the revision list. Throws if revision appears to
+    be invalid for the given |dep|."""
+    assert len(dep.safesync_url) > 0
+    handle = urllib.urlopen(dep.safesync_url)
+    rev = handle.read().strip()
+    handle.close()
+    if not len(rev):

[M-A Ruel, 2011/12/21 20:24:56]

if not rev:

[Dan Beam, 2011/12/21 23:32:48]

Done.

+      raise gclient_utils.Error(
+          'It appears your safesync_url (%s) is not working properly\n'
+          '(as it returned an empty response). Check your config.' %
+          dep.safesync_url)
+    scm = gclient_scm.CreateSCM(dep.url, dep.root.root_dir, dep.name)
+    safe_rev = scm.GetUsableRev(rev=rev, options=self._options)
+    if self._options.verbose:
+      print('Using safesync_url revision: %s.\n' % safe_rev)
+    self._options.revisions.append('%s@%s' % (dep.name, safe_rev))
+
   def RunOnDeps(self, command, args):
     """Runs a command on each dependency in a client and its dependencies.