[depot_tools] Disabling new git checkouts with safesync_urls until fixed.

[depot_tools] Disabling new git checkouts with safesync_urls until fixed.

R=maruel@chromium.org
TEST=gclient sync a freshly configured client.
BUG=106015
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115452

[Dan Beam, 2011-12-21 05:25:03]

ping

[M-A Ruel, 2011-12-21 18:31:01]

http://codereview.chromium.org/8994016/diff/2001/gclient.py
File gclient.py (right):

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode922
gclient.py:922: elif s.safesync_url:
I'd rather move everything in this condition into the function.

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode935
gclient.py:935: not os.path.isdir(os.path.join(s.root.root_dir, s.name)) and
I'd rather have GetUsableRev() handles that, it'd be much cleaner.

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode962
gclient.py:962: """Find a valid revision from the content of the safesync_url
and apply it
Finds

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode969
gclient.py:969: raise gclient_utils.Error(
You know that you are also raising inside GetUsableRev()? I think here is the
better place.

[Dan Beam, 2011-12-21 20:20:11]

http://codereview.chromium.org/8994016/diff/2001/gclient.py
File gclient.py (right):

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode922
gclient.py:922: elif s.safesync_url:
On 2011/12/21 18:31:02, Marc-Antoine Ruel wrote:
> I'd rather move everything in this condition into the function.

Done.

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode935
gclient.py:935: not os.path.isdir(os.path.join(s.root.root_dir, s.name)) and
On 2011/12/21 18:31:02, Marc-Antoine Ruel wrote:
> I'd rather have GetUsableRev() handles that, it'd be much cleaner.

Done.

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode962
gclient.py:962: """Find a valid revision from the content of the safesync_url
and apply it
On 2011/12/21 18:31:02, Marc-Antoine Ruel wrote:
> Finds

Done.

http://codereview.chromium.org/8994016/diff/2001/gclient.py#newcode969
gclient.py:969: raise gclient_utils.Error(
On 2011/12/21 18:31:02, Marc-Antoine Ruel wrote:
> You know that you are also raising inside GetUsableRev()? I think here is the
> better place.

Done.

[Dan Beam, 2011-12-21 20:23:14]

Also, should I add a section in UsingNewGit about how using a safesync_url for
managed git repo requires you to first checkout the git URL and add a git-svn
remote?

[M-A Ruel, 2011-12-21 20:24:51]

On 2011/12/21 20:23:14, Dan Beam wrote:
> Also, should I add a section in UsingNewGit about how using a safesync_url for
> managed git repo requires you to first checkout the git URL and add a git-svn
> remote?

That'd be great.

lgtm

[M-A Ruel, 2011-12-21 20:24:56]

http://codereview.chromium.org/8994016/diff/5002/gclient.py
File gclient.py (right):

http://codereview.chromium.org/8994016/diff/5002/gclient.py#newcode950
gclient.py:950: if not len(rev):
if not rev:

[Dan Beam, 2011-12-21 23:32:48]

http://codereview.chromium.org/8994016/diff/5002/gclient.py
File gclient.py (right):

http://codereview.chromium.org/8994016/diff/5002/gclient.py#newcode950
gclient.py:950: if not len(rev):
On 2011/12/21 20:24:56, Marc-Antoine Ruel wrote:
> if not rev:

Done.

[commit-bot: I haz the power, 2011-12-22 00:15:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/8994016/9002

[commit-bot: I haz the power, 2011-12-22 00:23:05]

Change committed as 115452