WebUI TaskManager: Delay scripts loading.

chrome/browser/resources/task_manager/includes.js

Index: chrome/browser/resources/task_manager/includes.js
diff --git a/chrome/browser/resources/task_manager/includes.js b/chrome/browser/resources/task_manager/includes.js
index 75708b12c5929a0de7e0b4302400072f983d8e16..b1ca9c179d51ae746066a84331cf70c0f621ff94 100644
--- a/chrome/browser/resources/task_manager/includes.js
+++ b/chrome/browser/resources/task_manager/includes.js
@@ -39,7 +39,9 @@ var script = [
   'cr/ui/table.js',
 
   'cr/ui/grid.js',
+];
 
+var scriptDelayed = [
   'cr/ui/command.js',
   'cr/ui/position_util.js',
   'cr/ui/menu_item.js',
@@ -47,6 +49,8 @@ var script = [
   'cr/ui/context_menu_handler.js',
 ];
 
+var loadDelayedIncludes;
+
 (function() {
   // Switch to 'test harness' mode when loading from a file url.
   var isHarness = document.location.protocol == 'file:';
@@ -63,4 +67,24 @@ var script = [
     document.write('<script src="' + prefix + 'js/' + script[i] +
                    '"><\/script>');
   }
+
+  /**
+   * Loads delayed scripts.
+   * This function is called by TaskManager::initalize() in main.js.
+   */
+  loadDelayedIncludes = function(taskmanager) {
+    // Number of remaining scripts to load.
+    var remain = scriptDelayed.length;
+
+    // Waits for initialization of task manager.
+    for (var i = 0; i < scriptDelayed.length; ++i) {

[arv (Not doing code reviews), 2012/01/17 21:47:06]

Prefer i++ in JS

[yoshiki, 2012/01/18 16:54:29]

Done.

+      var s = document.createElement('script');
+      s.onload = function(e) {
+        if (!--remain)
+          taskmanager.delayedInitialize();
+      };
+      s.src = prefix + 'js/' + scriptDelayed[i];
+      document.body.appendChild(s);

[arv (Not doing code reviews), 2012/01/17 21:47:06]

document.head.appendChild seems slightly more correct

[yoshiki, 2012/01/18 16:54:29]

Done.

+    }
+  };
 })();