WebUI TaskManager: Delay scripts loading.

chrome/browser/resources/task_manager/main.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @constructor */
 function TaskManager() { }
 
 cr.addSingletonGetter(TaskManager);
 
 /*
@@ skipping 133 matching lines @@
   /**
    * Initializes taskmanager.
    * @public
    */
   initialize: function (dialogDom, opt) {
     if (!dialogDom) {
       console.log('ERROR: dialogDom is not defined.');
       return;
     }
 
+    metrics.startInterval('Load.DOM');
+
     this.opt_ = opt;
 
     this.initialized_ = true;
     this.enableTaskManager();
 
     this.dialogDom_ = dialogDom;
     this.document_ = dialogDom.ownerDocument;
 
-    $('close-window').addEventListener('click', this.close.bind(this));
-    $('kill-process').addEventListener('click',
-                                       this.killSelectedProcesses.bind(this));
-    $('about-memory-link').addEventListener('click',
-                                            this.openAboutMemory.bind(this));
+    var ary = this.dialogDom_.querySelectorAll('[visibleif]');
+    for (var i = 0; i < ary.length; i++) {
+      var expr = ary[i].getAttribute('visibleif');
+      if (!eval(expr))

[arv (Not doing code reviews), 2011/12/19 22:57:14]

eval should be prevented if possible. What is its purpose here?

[yoshiki, 2011/12/20 15:18:25]

Done.

+        ary[i].hidden = true;
+    }
 
     this.is_column_shown_ = [];
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       this.is_column_shown_[i] = DEFAULT_COLUMNS[i][3];
     }
 
     this.localized_column_ = [];
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column_label_id = DEFAULT_COLUMNS[i][1];
       var localized_label = localStrings.getString(column_label_id);
@@ skipping 28 matching lines @@
               var aValues = a[value_id];
               var bValues = b[value_id];
               var aValue = aValues && aValues[0] || 0;
               var bvalue = bValues && bValues[0] || 0;
               return dm.defaultValuesCompareFunction(aValue, bvalue);
           };
       }();
       dm.setCompareFunction(column_id, compare_func);
     }
 
-    var ary = this.dialogDom_.querySelectorAll('[visibleif]');
-    for (var i = 0; i < ary.length; i++) {
-      var expr = ary[i].getAttribute('visibleif');
-      if (!eval(expr))
-        ary[i].hidden = true;
+    this.initTable_();
+
+    // Populate the static localized strings.
+    i18nTemplate.process(this.document_, templateData);
+
+    metrics.recordInterval('Load.DOM');
+    metrics.recordInterval('Load.Total');
+
+    loadDelayedIncludes(this);
+  },
+
+  /**
+   * Additional initialization of taskmanager. This function is called when
+   * the loading of delayed scripts finished.
+   * @public

[James Hawkins, 2011/12/19 18:35:56]

In general we don't specify @public since it's implied.

[yoshiki, 2011/12/20 15:18:25]

Done.

+   */
+  delayedInitialize: function () {
+    $('close-window').addEventListener('click', this.close.bind(this));
+    $('kill-process').addEventListener('click',
+                                       this.killSelectedProcesses.bind(this));
+    $('about-memory-link').addEventListener('click',
+                                            this.openAboutMemory.bind(this));
+    this.initColumnMenu_();
+    this.initTableMenu_();
+
+    if (this.delayedInitLabels_) {
+      while (this.delayedInitLabels_.length > 0)
+        this.delayedInitLabels_.pop().call();
     }
 
-    this.initTable_();
-    this.initColumnMenu_();
-    this.initTableMenu_();
+    this.isFinishedInitDelayed_ = true;
     this.table_.redraw();
   },
 
   initColumnModel_: function () {
     var table_columns = new Array();
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       if (!this.is_column_shown_[i])
         continue;
 
       var column = DEFAULT_COLUMNS[i];
@@ skipping 119 matching lines @@
           cm.getRenderFunction(i).call(null, dataItem, cm.getId(i), table));
 
       listItem.appendChild(cell);
     }
     listItem.data = dataItem;
 
     return listItem;
   },
 
   renderColumn_: function(entry, columnId, table) {
+    this.delayedInitLabels_ = [];
+
     var container = this.document_.createElement('div');
     container.className = 'detail-container-' + columnId;
 
     if (entry && entry[columnId]) {
       container.id = 'detail-container-' + columnId + '-pid' + entry.processId;
 
       for (var i = 0; i < entry[columnId].length; i++) {
         var label = document.createElement('div');
         if (columnId == 'title') {
           var image = this.document_.createElement('img');
           image.className = 'detail-title-image';
           image.src = entry['icon'][i];
           label.appendChild(image);
           var text = this.document_.createElement('div');
           text.className = 'detail-title-text';
           text.textContent = entry['title'][i];
           label.appendChild(text);
 
-          cr.ui.contextMenuHandler.addContextMenuProperty(label);
-          label.contextMenu = this.tableContextMenu_;
+          var addContextMenu = function() {

[arv (Not doing code reviews), 2011/12/19 22:57:14]

This will not work correctly. label changes as you iterate and this just
captures the last one.

[yoshiki, 2011/12/20 15:18:25]

Done.

+            cr.ui.contextMenuHandler.addContextMenuProperty(label);
+            label.contextMenu = this.tableContextMenu_;
+          };
+
+          if (this.isFinishedInitDelayed_)
+            addContextMenu.call(this);
+          else
+            this.delayedInitLabels_.push(addContextMenu.bind(this));
 
           label.addEventListener('dblclick', (function(uniqueId) {
               this.activatePage(uniqueId);
           }).bind(this, entry['uniqueId'][i]));
 
           label.data = entry;
           label.index_in_group = i;
         } else {
           label.textContent = entry[columnId][i];
         }
@@ skipping 76 matching lines @@
 
   onCommandCanExecute_: function(event) {
     event.canExecute = true;
   },
 
   /**
    * Store resourceIndex of target resource of context menu, because resource
    * will be replaced when it is refleshed.
    */
   onTableContextMenuOpened_: function (e) {
+    if (!this.isFinishedInitDelayed_)
+      return;
+
     var mc = this.table_menu_commands_;
     var inspect_menuitem =
         mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + '-inspect'].menuitem;
     var activate_menuitem =
         mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + '-activate'].menuitem;
 
     // Disabled by default.
     inspect_menuitem.disabled = true;
     activate_menuitem.disabled = true;
 
@@ skipping 88 matching lines @@
   taskmanager.onTaskChange(start, length, tasks);
 }
 
 function taskRemoved(start, length) {
   // Sometimes this can get called too early.
   if (!taskmanager)
     return;
   taskmanager.onTaskRemove(start, length);
 }