Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 103268) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,3 +1,1947 @@ |
+2011-12-10 Noel Gordon <noel.gordon@gmail.com> |
+ |
+ WebPImageDecoder progressive decodes fail to decode valid images |
+ https://bugs.webkit.org/show_bug.cgi?id=74062 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ The WEBP header is followed by a so-called P0 header, then some data to |
+ decode. If a partial P0 header is received during progressive decodes, |
+ WebPIDecGetRGB() returns false; that makes the decoder enter the failed |
+ state, no image appears on the page. |
+ |
+ James Zern (webp) recommended the following via e-mail: |
+ |
+ WebPIUpdate() validates input data, and will return an error status for |
+ malformed data (bit-stream error, invalid data). Otherwise, it returns |
+ OK or SUSPENDED. OK means that decoding is done/complete/no-error, and |
+ SUSPENDED means more input data is needed to complete decoding. A NULL |
+ return from WebPIDecGetRGB() is valid at this time due to a partial P0, |
+ and should not be interpreted as a decoding failure. |
+ |
+ No new tests. Not something DumpRenderTree can easily test. |
+ |
+ * platform/image-decoders/webp/WEBPImageDecoder.cpp: |
+ (WebCore::WEBPImageDecoder::decode): A NULL WebPIDecGetRGB() return is |
+ acceptable here. Return false instead of failing the decoder. |
+ |
+2011-12-09 Benjamin Poulain <bpoulain@apple.com> |
+ |
+ Add the FileSystem functions of iOS |
+ https://bugs.webkit.org/show_bug.cgi?id=74164 |
+ |
+ Reviewed by David Kilzer. |
+ |
+ Two functions are needed on iOS for temporary files and directories. |
+ |
+ * WebCore.exp.in: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/ios/FileSystemIOS.h: Added. |
+ * platform/ios/FileSystemIOS.mm: Added. |
+ (WebCore::createTemporaryDirectory): |
+ (WebCore::createTemporaryFile): |
+ |
+2011-12-09 Jacky Jiang <zhajiang@rim.com> |
+ |
+ Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=74197 |
+ |
+ The bufferedData() was removed in r95120. |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Trivial fix, so no new tests. |
+ |
+ * platform/network/blackberry/ResourceHandleBlackBerry.cpp: |
+ |
+2011-12-09 Eric Penner <epenner@google.com> |
+ |
+ [chromium] Prevent ASSERT in legitimate out-of-memory case. |
+ https://bugs.webkit.org/show_bug.cgi?id=74215 |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::updateCompositorResources): |
+ |
+2011-12-09 Arko Saha <arko@motorola.com> |
+ |
+ NameNodeListCache should be invalidated when name attribute changes/modified. |
+ https://bugs.webkit.org/show_bug.cgi?id=70810 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Test: fast/dom/getelementsbyname-invalidation-cache.html |
+ |
+ * html/HTMLAnchorElement.cpp: |
+ (WebCore::HTMLAnchorElement::parseMappedAttribute): |
+ * html/HTMLAppletElement.cpp: |
+ (WebCore::HTMLAppletElement::parseMappedAttribute): |
+ * html/HTMLElement.cpp: |
+ (WebCore::HTMLElement::parseMappedAttribute): |
+ * html/HTMLEmbedElement.cpp: |
+ (WebCore::HTMLEmbedElement::parseMappedAttribute): |
+ * html/HTMLFormElement.cpp: |
+ (WebCore::HTMLFormElement::parseMappedAttribute): |
+ * html/HTMLFrameElementBase.cpp: |
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute): |
+ * html/HTMLIFrameElement.cpp: |
+ (WebCore::HTMLIFrameElement::parseMappedAttribute): |
+ * html/HTMLImageElement.cpp: |
+ (WebCore::HTMLImageElement::parseMappedAttribute): |
+ * html/HTMLMapElement.cpp: |
+ (WebCore::HTMLMapElement::parseMappedAttribute): |
+ * html/HTMLMetaElement.cpp: |
+ (WebCore::HTMLMetaElement::parseMappedAttribute): |
+ * html/HTMLObjectElement.cpp: |
+ (WebCore::HTMLObjectElement::parseMappedAttribute): |
+ * html/HTMLParamElement.cpp: |
+ (WebCore::HTMLParamElement::parseMappedAttribute): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix Lion release build. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ |
+2011-12-09 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ [FileSystem API] Entry.remove successCallback is required |
+ https://bugs.webkit.org/show_bug.cgi?id=69639 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fast/filesystem/simple-required-arguments-remove.html |
+ |
+ * fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter |
+ |
+2011-12-09 Tim Horton <timothy_horton@apple.com> |
+ |
+ background-image transitions trigger between equivalent images |
+ https://bugs.webkit.org/show_bug.cgi?id=74229 |
+ <rdar://problem/10558627> |
+ |
+ Reviewed by Darin Adler. |
+ Patch by Simon Fraser. |
+ |
+ For animation property wrappers around StyleImage properties, |
+ test the equivalence of the image itself, instead of equality of |
+ the StyleImage pointer. |
+ |
+ Test: transitions/equivalent-background-image-no-transition.html |
+ |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper): |
+ (WebCore::StyleImagePropertyWrapper::equals): |
+ (WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper): |
+ (WebCore::FillLayerStyleImagePropertyWrapper::equals): |
+ (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): |
+ (WebCore::AnimationBase::ensurePropertyMap): |
+ |
+2011-12-09 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Small style fix on DragDataBlackBerry.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=74171 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Style fix, no function impact, no new tests. |
+ |
+ * platform/blackberry/DragDataBlackBerry.cpp: |
+ (WebCore::DragData::containsURL): |
+ (WebCore::DragData::asFilenames): |
+ (WebCore::DragData::asURL): |
+ (WebCore::DragData::asFragment): |
+ |
+2011-12-09 Tony Chang <tony@chromium.org> |
+ |
+ add css parsing for flex-flow: wrap and wrap-reverse |
+ https://bugs.webkit.org/show_bug.cgi?id=74008 |
+ |
+ Reviewed by Ojan Vafai. |
+ |
+ Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values). |
+ |
+ * css/CSSComputedStyleDeclaration.cpp: |
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists. |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList. |
+ * css/CSSPrimitiveValueMappings.h: |
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): |
+ (WebCore::CSSPrimitiveValue::operator EFlexWrap): |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit. |
+ (WebCore::ApplyPropertyFlexFlow::applyInitialValue): |
+ (WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one |
+ CSS property. |
+ (WebCore::ApplyPropertyFlexFlow::createHandler): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ * css/CSSValueKeywords.in: |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::flexWrap): |
+ (WebCore::InheritedFlags::setFlexWrap): |
+ (WebCore::InheritedFlags::initialFlexWrap): |
+ * rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values. |
+ * rendering/style/StyleFlexibleBoxData.cpp: |
+ (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): |
+ (WebCore::StyleFlexibleBoxData::operator==): |
+ * rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values. |
+ |
+2011-12-09 KwangHyuk Kim <hyuki.kim@samsung.com> |
+ |
+ [EFL] Add RefPtrEfl specialization for evas_object. |
+ https://bugs.webkit.org/show_bug.cgi?id=73790 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ As evas_object is also based on reference count, RefPtr is applied for evas_object. |
+ |
+ * PlatformEfl.cmake: |
+ * platform/efl/RefPtrEfl.cpp: Added. |
+ (WTF::refIfNotNull): |
+ (WTF::derefIfNotNull): |
+ * platform/efl/RefPtrEfl.h: Added. |
+ |
+2011-12-09 Tony Chang <tony@chromium.org> |
+ |
+ REGRESSION(102234): 2-3% layout regression |
+ https://bugs.webkit.org/show_bug.cgi?id=74141 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Don't allocate a RuleSet when there are no regions. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::initForRegionStyling): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix assertion failure in ScrollAnimatorMac |
+ https://bugs.webkit.org/show_bug.cgi?id=74222 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): |
+ This can be called with a nil scrollerImp, just return NSZeroPoint when that happens. |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Move the "is currently drawing into layer" flag out into ScrollbarThemeMac |
+ https://bugs.webkit.org/show_bug.cgi?id=74217 |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead. |
+ |
+ * platform/mac/ScrollAnimatorMac.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate layer]): |
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): |
+ * platform/mac/ScrollbarThemeMac.h: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer): |
+ (WebCore::ScrollbarThemeMac::paint): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Minor cleanup in ScrollAnimatorMac.mm |
+ https://bugs.webkit.org/show_bug.cgi?id=74211 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ No need to get the scrollbar from the scroll animator anymore. |
+ |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter. |
+ |
+2011-12-09 David Levin <levin@chromium.org> |
+ |
+ Regression(r53595): Sync xhr requests in workers aren't terminated on worker close. |
+ https://bugs.webkit.org/show_bug.cgi?id=71695 |
+ |
+ Reviewed by Zoltan Herczeg. |
+ |
+ Overview: Message loops rely on the message queue being killed in order |
+ to exit. r53595 stopped this from happening because killing a message loop |
+ would also stop it from doing database clean up tasks. The database clean up |
+ tasks needed to be tasks due to ordering issues. (They wanted to run after |
+ certain order tasks were run.) This was solved by once again terminating |
+ the message queue but then still runnning clean-up tasks from the killed |
+ message queue. |
+ |
+ * workers/WorkerRunLoop.cpp: |
+ (WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks. |
+ (WebCore::WorkerRunLoop::runInMode): |
+ (WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks. |
+ (WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks |
+ from running after the loop has been terminated. |
+ * workers/WorkerRunLoop.h: |
+ (WebCore::WorkerRunLoop::terminated): Just made it const. |
+ * workers/WorkerThread.cpp: |
+ (WebCore::WorkerThreadShutdownFinishTask::performTask): Removed |
+ the terminate clause since it was put back in stop. |
+ (WebCore::WorkerThread::stop): Terminate the run loop so |
+ that all loops will exit and clean up tasks will run. Also removed a comment |
+ about nested workers because nested workers are no longer imminent and the |
+ issue mentioned is one of many that should logically be investigated -- behavior correctness |
+ in the face of different orderings of shutdown between the document and each worker -- |
+ when implementing them. |
+ |
+2011-12-09 Tony Chang <tony@chromium.org> |
+ |
+ Unreviewed, rolling out r102416. |
+ http://trac.webkit.org/changeset/102416 |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ Chromium Win clobber builds are failing. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): |
+ * WebCore.gypi: |
+ * bindings/scripts/generate-bindings.pl: |
+ * page/DOMWindow.idl: |
+ * webaudio/DOMWindowWebAudio.idl: Removed. |
+ |
+2011-12-09 Eric Carlson <eric.carlson@apple.com> |
+ |
+ JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable |
+ https://bugs.webkit.org/show_bug.cgi?id=72179 |
+ |
+ Reviewed by Geoff Garen. |
+ |
+ Tests: media/track/text-track-cue-is-reachable.html |
+ media/track/text-track-is-reachable.html |
+ |
+ * GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp. |
+ * Target.pri: Ditto. |
+ * WebCore.gypi: Ditto. |
+ * WebCore.xcodeproj/project.pbxproj: Ditto |
+ * bindings/js/JSBindingsAllInOne.cpp: Ditto. |
+ |
+ * bindings/js/JSTextTrackCueCustom.cpp: Added. |
+ (WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New. |
+ (WebCore::JSTextTrackCueOwner::visitChildren): New. |
+ |
+ * bindings/js/JSTextTrackCustom.cpp: Added. |
+ (WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New. |
+ (WebCore::JSTextTrack::visitChildren): New, mark all cues. |
+ * bindings/js/JSTextTrackCustom.h: Added. |
+ (WebCore::root): New. |
+ |
+ * bindings/js/JSTextTrackListCustom.cpp: |
+ (WebCore::JSTextTrackList::visitChildren): New, mark all tracks. |
+ |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*. |
+ |
+ * html/LoadableTextTrack.h: |
+ (WebCore::LoadableTextTrack::trackElement): New, return the <track>. |
+ |
+ * html/TextTrack.cpp: |
+ (WebCore::TextTrack::TextTrack): Initialize m_mediaElement. |
+ * html/TextTrack.h: |
+ (WebCore::TextTrack::setMediaElement): New. |
+ (WebCore::TextTrack::mediaElement): Ditto. |
+ |
+ * html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction. |
+ |
+ * html/TextTrackCue.idl: Add CustomIsReachable. |
+ |
+ * html/track/TextTrackList.cpp: |
+ (TextTrackList::append): Set track's media element. |
+ (TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr. |
+ * html/track/TextTrackList.h: |
+ * html/track/TextTrackList.idl: Add CustomMarkFunction |
+ |
+2011-12-09 Chris Fleizach <cfleizach@apple.com> |
+ |
+ WebKit should ignore images with @alt matching only whitespace |
+ https://bugs.webkit.org/show_bug.cgi?id=74189 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: accessibility/img-alt-tag-only-whitespace.html |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Remove NSAnimationContext calls |
+ https://bugs.webkit.org/show_bug.cgi?id=74207 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration: |
+ are essentially no-ops. Remove them. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Rename scrollAnimatorDestroyed to invalidate |
+ https://bugs.webkit.org/show_bug.cgi?id=74206 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is |
+ destroyed, rename it to something more neutral. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollAnimationHelperDelegate invalidate]): |
+ (-[WebScrollbarPartAnimation invalidate]): |
+ (-[WebScrollbarPainterDelegate invalidate]): |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac |
+ https://bugs.webkit.org/show_bug.cgi?id=74204 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since |
+ painting has nothing to do with animation. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]): |
+ (-[WebScrollbarPainterControllerDelegate invalidate]): |
+ (-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): |
+ (-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): |
+ (-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): |
+ (-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): |
+ (-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): |
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ |
+2011-12-09 Jarred Nicholls <jarred@sencha.com> |
+ |
+ [JSC] Allow cached attributes in bindings that declare a custom mark function |
+ https://bugs.webkit.org/show_bug.cgi?id=74187 |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ No new tests, current binding tests are sufficient. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateImplementation): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Remove duplicate animation ivars |
+ https://bugs.webkit.org/show_bug.cgi?id=74194 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate |
+ vertical/horizontal animation objects, so get rid of them. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate cancelAnimations]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ WebScrollbarPartAnimation should only know about the scrollbar it's animating |
+ https://bugs.webkit.org/show_bug.cgi?id=74192 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]): |
+ Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here |
+ so we don't have to do it in all the call sites. |
+ |
+ (-[WebScrollbarPartAnimation startAnimation]): |
+ Update the scrollbar painter. |
+ |
+ (-[WebScrollbarPartAnimation setCurrentProgress:]): |
+ Just invalidate the scrollbar we're animating. |
+ |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ Update call sites to use the new designated initializer. |
+ |
+2011-12-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> |
+ |
+ Inspector: Don't translate the context when rendering the highlights on a tiled layer. |
+ https://bugs.webkit.org/show_bug.cgi?id=74085 |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ When the frame view is using fixed layouting, the page overlay is the size of the whole |
+ page and the context shouldn't be translated. The visible rect is still used in that |
+ case to display element titles within the visible rect. |
+ |
+ Also: |
+ - Rename overlayRect to visibleRect to reduce confusion in this case. |
+ - Remove the superfluous boundingBox check. |
+ |
+ * inspector/DOMNodeHighlighter.cpp: |
+ |
+2011-12-09 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Unreviewed inspector utilities syntax fix. |
+ |
+ * inspector/front-end/utilities.js: |
+ (): |
+ |
+2011-12-09 Joone Hur <joone.hur@collabora.co.uk>, Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> |
+ |
+ [GTK] Initial implementation of Accelerated Compositing using Clutter |
+ https://bugs.webkit.org/show_bug.cgi?id=73319 |
+ |
+ Reviewed by Gustavo Noronha Silva. |
+ |
+ No new tests added as this feature will be able to reuse the existing |
+ CSS3 transforms layout tests. |
+ |
+ * GNUmakefile.am: Include WebCore/platform/graphics/clutter path. |
+ * GNUmakefile.list.am: Add GraphicsLayerClutter. |
+ * platform/clutter/GRefPtrClutter.cpp: Added. |
+ (WTF::adoptGRef): |
+ (WTF::ClutterActor): |
+ * platform/clutter/GRefPtrClutter.h: Added. |
+ * platform/graphics/GraphicsLayer.h: Define PlatformLayer type, which represents ClutterActor. |
+ * platform/graphics/clutter/GraphicsLayerClutter.cpp: Boilerplate implementation. |
+ (WebCore::GraphicsLayerClutter::GraphicsLayerClutter): |
+ (WebCore::GraphicsLayerClutter::platformLayer): |
+ * platform/graphics/clutter/GraphicsLayerClutter.h: Boilerplate implementation. |
+ |
+2011-12-08 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects. |
+ https://bugs.webkit.org/show_bug.cgi?id=74084 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Test: inspector/map.html |
+ |
+ * inspector/front-end/treeoutline.js: |
+ (TreeOutline): |
+ (): |
+ (TreeElement.prototype.collapse): |
+ (TreeElement.prototype.expand): |
+ * inspector/front-end/utilities.js: |
+ (): |
+ |
+2011-12-09 Peter Rybin <peter.rybin@gmail.com> |
+ |
+ Web Inspector: [protocol] generate C++ classes for protocol JSON named types |
+ https://bugs.webkit.org/show_bug.cgi?id=72835 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Extends python generator functionality. |
+ Makes constructor in InspectorObject public. |
+ |
+ * inspector/CodeGeneratorInspector.py: |
+ * inspector/InspectorValues.h: |
+ |
+2011-12-08 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> |
+ |
+ [Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated. |
+ https://bugs.webkit.org/show_bug.cgi?id=73591 |
+ |
+ Reviewed by Noam Rosenthal. |
+ |
+ Implementation of helper function to remove all GL allocated tiles |
+ when QQuickWebView gets removed from canvas. |
+ |
+ Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas). |
+ |
+ * platform/graphics/texmap/TextureMapperNode.cpp: |
+ (WebCore::TextureMapperNode::purgeNodeTexturesRecursive): |
+ * platform/graphics/texmap/TextureMapperNode.h: |
+ |
+2011-12-08 Leo Yang <leo.yang@torchmobile.com.cn> |
+ |
+ Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp} |
+ https://bugs.webkit.org/show_bug.cgi?id=73791 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Other main contributors: |
+ Joe Mason <jmason@rim.com> |
+ Lianghui Chen <liachen@rim.com> |
+ Charles Wei <charles.wei@torchmobile.com.cn> |
+ |
+ Initial upstream, can't be built yet, no new tests. |
+ |
+ * platform/network/blackberry/DeferredData.cpp: Added. |
+ * platform/network/blackberry/DeferredData.h: Added. |
+ * platform/network/blackberry/NetworkJob.cpp: Added. |
+ * platform/network/blackberry/NetworkJob.h: Added. |
+ * platform/network/blackberry/NetworkManager.cpp: Added. |
+ * platform/network/blackberry/NetworkManager.h: Added. |
+ |
+2011-12-08 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent |
+ https://bugs.webkit.org/show_bug.cgi?id=74028 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls |
+ to notifyNodeListsAttributeChanged at appropriate places. |
+ |
+ Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and |
+ notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to |
+ invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively. |
+ |
+ * dom/Attr.cpp: |
+ (WebCore::Attr::childrenChanged): |
+ * dom/ContainerNode.cpp: |
+ (WebCore::ContainerNode::childrenChanged): |
+ * dom/Document.cpp: |
+ (WebCore::Document::updateRangesAfterNodeChanges): |
+ * dom/Document.h: |
+ * dom/NamedNodeMap.cpp: |
+ (WebCore::NamedNodeMap::addAttribute): |
+ (WebCore::NamedNodeMap::removeAttribute): |
+ * dom/Node.cpp: |
+ (WebCore::removeNodeListCacheIfPossible): |
+ (WebCore::Node::unregisterDynamicNodeList): |
+ (WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges): |
+ (WebCore::Node::invalidateNodeListsCacheAfterNodeChanges): |
+ (WebCore::Node::dispatchSubtreeModifiedEvent): |
+ * dom/Node.h: |
+ * dom/NodeRareData.h: |
+ * dom/StyledElement.cpp: |
+ (WebCore::StyledElement::classAttributeChanged): |
+ |
+2011-12-08 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ Unreviewed, rolling out r102418. |
+ http://trac.webkit.org/changeset/102418 |
+ https://bugs.webkit.org/show_bug.cgi?id=71870 |
+ |
+ Caused Chromium build failure. |
+ |
+ * CMakeLists.txt: |
+ * DerivedSources.make: |
+ * DerivedSources.pri: |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSWebGLRenderingContextCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: |
+ (WebCore::toV8Object): |
+ * html/canvas/WebGLExtension.h: |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::getExtension): |
+ (WebCore::WebGLRenderingContext::getSupportedExtensions): |
+ (WebCore::WebGLRenderingContext::maybeRestoreContext): |
+ * html/canvas/WebGLRenderingContext.h: |
+ * html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp. |
+ (WebCore::WebKitLoseContext::WebKitLoseContext): |
+ (WebCore::WebKitLoseContext::~WebKitLoseContext): |
+ (WebCore::WebKitLoseContext::getName): |
+ (WebCore::WebKitLoseContext::create): |
+ (WebCore::WebKitLoseContext::loseContext): |
+ (WebCore::WebKitLoseContext::restoreContext): |
+ * html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h. |
+ * html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl. |
+ |
+2011-12-08 Fady Samuel <fsamuel@chromium.org> |
+ |
+ [Chromium] Enable viewport metatag |
+ https://bugs.webkit.org/show_bug.cgi?id=73495 |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ Recompute viewpot parameters on frame rect resize. |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::setFrameRect): |
+ |
+2011-12-08 Kent Tamura <tkent@chromium.org> |
+ |
+ Build fix for r102419. |
+ https://bugs.webkit.org/show_bug.cgi?id=73916 |
+ |
+ * platform/PopupMenuClient.h: |
+ (WebCore::PopupMenuClient::listBoxSelectItem): |
+ Remove unused argument names. |
+ |
+2011-12-08 Kentaro Hara <haraken@chromium.org> |
+ |
+ Unreviewed. Rebaselined run-bindings-tests results. |
+ |
+ * bindings/scripts/test/JS/JSFloat64Array.cpp: |
+ * bindings/scripts/test/JS/JSTestEventConstructor.cpp: |
+ * bindings/scripts/test/JS/JSTestInterface.cpp: |
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
+ * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: |
+ * bindings/scripts/test/JS/JSTestObj.cpp: |
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: |
+ |
+2011-12-08 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent |
+ https://bugs.webkit.org/show_bug.cgi?id=73534 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Other main contributors: |
+ Mike Fenton <mifenton@rim.com> |
+ Joe Mason <jmason@rim.com> |
+ Max Feil <mfeil@qnx.com> |
+ Lukas Sydorowski <lsydorowski@rim.com> |
+ Crystal Zhang <haizhang@rim.com> |
+ |
+ Initial upstream, no new tests. |
+ |
+ * platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added. |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): |
+ (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType): |
+ * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added. |
+ (WebCore::keyIdentifierForBlackBerryCharacter): |
+ (WebCore::windowsKeyCodeForBlackBerryCharacter): |
+ (WebCore::adjustCharacterFromOS): |
+ (WebCore::toWebCorePlatformKeyboardEventType): |
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): |
+ (WebCore::PlatformKeyboardEvent::currentCapsLockState): |
+ (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): |
+ (WebCore::PlatformKeyboardEvent::getCurrentModifierState): |
+ |
+2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r101619. |
+ http://trac.webkit.org/changeset/101619 |
+ https://bugs.webkit.org/show_bug.cgi?id=74158 |
+ |
+ this patch produces bad behaviour on mac (Requested by |
+ jeremya_ on #webkit). |
+ |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::handleMouseMoveEvent): |
+ (WebCore::EventHandler::dragSourceEndedAt): |
+ * rendering/RenderLayer.cpp: |
+ (WebCore::RenderLayer::updateHoverActiveState): |
+ |
+2011-12-08 Adam Klein <adamk@chromium.org> |
+ |
+ [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics |
+ https://bugs.webkit.org/show_bug.cgi?id=73492 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fast/mutation/inline-event-listener.html |
+ |
+ * bindings/v8/V8LazyEventListener.cpp: |
+ (WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy. |
+ |
+2011-12-08 Hayato Ito <hayato@chromium.org> |
+ |
+ Suppress rendering of light children when ShadowRoot is dynamically created. |
+ https://bugs.webkit.org/show_bug.cgi?id=72441 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html |
+ fast/dom/shadow/dynamically-created-shadow-root.html |
+ |
+ * dom/Element.cpp: |
+ (WebCore::Element::setShadowRoot): |
+ |
+2011-12-08 Pierre Rossi <pierre.rossi@gmail.com> |
+ |
+ Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision. |
+ https://bugs.webkit.org/show_bug.cgi?id=73916 |
+ |
+ This was needed for Qt since the mobile theme, which can be picked |
+ up at runtime, delegates the rendering of list boxes. |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ No new tests, there's no functional change. |
+ |
+ * html/HTMLSelectElement.cpp: |
+ (WebCore::HTMLSelectElement::usesMenuList): |
+ * html/HTMLSelectElement.h: |
+ * platform/PopupMenuClient.h: |
+ (WebCore::PopupMenuClient::listBoxSelectItem): |
+ (WebCore::PopupMenuClient::multiple): |
+ * platform/qt/RenderThemeQtMobile.h: |
+ (WebCore::RenderThemeQtMobile::delegatesMenuListRendering): |
+ * rendering/RenderMenuList.cpp: |
+ (WebCore::RenderMenuList::multiple): |
+ * rendering/RenderMenuList.h: |
+ * rendering/RenderTheme.h: |
+ (WebCore::RenderTheme::delegatesMenuListRendering): |
+ |
+2011-12-08 Kenneth Russell <kbr@google.com> |
+ |
+ Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context |
+ https://bugs.webkit.org/show_bug.cgi?id=71870 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Rename largely done with do-webcore-rename with a couple of |
+ necessary manual fixups. Ran WebGL layout tests. |
+ |
+ * CMakeLists.txt: |
+ * DerivedSources.make: |
+ * DerivedSources.pri: |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSWebGLRenderingContextCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: |
+ (WebCore::toV8Object): |
+ * html/canvas/WebGLExtension.h: |
+ * html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp. |
+ (WebCore::WebGLLoseContext::WebGLLoseContext): |
+ (WebCore::WebGLLoseContext::~WebGLLoseContext): |
+ (WebCore::WebGLLoseContext::getName): |
+ (WebCore::WebGLLoseContext::create): |
+ (WebCore::WebGLLoseContext::loseContext): |
+ (WebCore::WebGLLoseContext::restoreContext): |
+ * html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h. |
+ * html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl. |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::getExtension): |
+ (WebCore::WebGLRenderingContext::getSupportedExtensions): |
+ (WebCore::WebGLRenderingContext::maybeRestoreContext): |
+ * html/canvas/WebGLRenderingContext.h: |
+ * html/canvas/WebKitLoseContext.cpp: Removed. |
+ * html/canvas/WebKitLoseContext.h: Removed. |
+ * html/canvas/WebKitLoseContext.idl: Removed. |
+ |
+2011-12-08 Kentaro Hara <haraken@chromium.org> |
+ |
+ Use the [Supplemental] IDL for webaudio attributes in Chromium |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ - Overview: Using the [Supplemental] IDL, this patch moves the attribute |
+ declarations of webaudio from DOMWindow.idl into a new IDL file |
+ webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained |
+ feature (aka a module). |
+ |
+ - This patch changes the build flow of WebCore.gyp as follows: |
+ |
+ Previous build flow: |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl generates .h and .cpp files for $idl; |
+ } |
+ |
+ New build flow (See the discussions in bug 72138 for more details): |
+ resolve-supplemental.pl depends on all IDL files; |
+ resolve-supplemental.pl reads all IDL files; |
+ resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX]; |
+ resolve-supplemental.pl outputs supplemental_dependency.tmp; |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl and supplemental_dependency.tmp; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl reads supplemental_dependency.tmp; |
+ generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl; |
+ } |
+ |
+ - This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL |
+ will be removed after build scripts for all platforms support the [Supplemental] IDL. |
+ The motivation for the [Supplemented] IDL is as follows: |
+ |
+ In order to support the [Supplemental] IDL, we need to |
+ (1) run resolve-supplemental.pl and generate supplemental_dependency.tmp |
+ (2) and run generate-bindings.pl with the supplemental_dependency.tmp. |
+ |
+ This build flow requires a change on the following build scripts, |
+ but changing all the build scripts all at once without any regression is too difficult: |
+ |
+ - DerivedSources.make |
+ - DerivedSources.pri |
+ - GNUmakefile.am |
+ - PlatformBlackBerry.cmake |
+ - UseJSC.cmake |
+ - UseV8.cmake |
+ - WebCore.vcproj/MigrateScripts |
+ - WebCore.vcproj/WebCore.vcproj |
+ - bindings/gobject/GNUmakefile.am |
+ - WebCore.gyp/WebCore.gyp |
+ |
+ Thus, we are planning to change the build scripts one by one, which implies that |
+ we need to allow the temporary state in which some build scripts support [Supplemental] IDL |
+ but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented]. |
+ The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental] |
+ in another IDL file somewhere, like this: |
+ |
+ DOMWindowWebAudio.idl: |
+ interface [ |
+ Supplemental=DOMWindow |
+ ] DOMWindowWebAudio { |
+ attribute attr1; |
+ attribute attr2; |
+ }; |
+ |
+ DOMWindow.idl: |
+ interface [ |
+ ] DOMWindow { |
+ attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL |
+ attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL. |
+ attribute attr3; |
+ attribute attr4; |
+ }; |
+ |
+ Assuming these IDL files, this patch implements the following logic in generate-bindings.pl: |
+ |
+ - If a given build script supports the [Supplemental] IDL, |
+ generate-bindings.pl ignores all attributes with the [Supplemented] IDL. |
+ - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL |
+ as normal attributes and instead ignores all attributes with the [Supplemental] IDL |
+ (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL). |
+ |
+ Tests: webaudio/* |
+ |
+ * WebCore.gyp/WebCore.gyp: Describes the build flow that I described above. |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command. |
+ * WebCore.gypi: Added DOMWindowWebAudio.idl. |
+ * bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL. |
+ * page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL. |
+ * webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl. |
+ |
+2011-12-08 Van Lam <vanlam@google.com> |
+ |
+ Caret keeps blinking during forward-delete |
+ https://bugs.webkit.org/show_bug.cgi?id=38564 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Currently updateAppearance determines if the caret should stop blinking |
+ based on whether or not the editing operation changed the position of |
+ the caret; so the caret stops blinking in case of typing text and |
+ backwards delete (which always displace the caret) but does not stop |
+ blinking in the case of forward delete (which does not displace the |
+ caret). |
+ |
+ Added a boolean member function shouldStopCaretBlinking in EditCommand |
+ which will return true if the object is a TypingCommand (my |
+ understanding here is that all TypingCommands should stop the caret |
+ from blinking for a cycle, currently 0.5 seconds). Then used this |
+ function to stop the caret from blinking if the last editing command |
+ is a TypingCommand. |
+ |
+ * editing/EditCommand.h: |
+ (WebCore::EditCommand::shouldStopCaretBlinking): |
+ * editing/FrameSelection.cpp: |
+ (WebCore::FrameSelection::updateAppearance): |
+ * editing/TypingCommand.h: |
+ (WebCore::TypingCommand::shouldStopCaretBlinking): |
+ |
+2011-12-08 Adam Klein <adamk@chromium.org> |
+ |
+ Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope |
+ https://bugs.webkit.org/show_bug.cgi?id=73964 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Re-landing r102267 with a fix for the clang build. |
+ |
+ No new tests, refactoring only. |
+ |
+ * dom/ChildListMutationScope.cpp: |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded): |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild): |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel): |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel): |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ WebScrollbarPainterDelegate should have a pointer to its Scrollbar |
+ https://bugs.webkit.org/show_bug.cgi?id=74149 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ This is another step towards making the scroll animation code more robust. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]): |
+ (-[WebScrollbarPainterDelegate scrollAnimator]): |
+ (-[WebScrollbarPainterDelegate layer]): |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ |
+2011-12-08 Rakesh KN <rakesh.kn@motorola.com> |
+ |
+ keyboard event doesn't fire while moving mouse with button pressed |
+ https://bugs.webkit.org/show_bug.cgi?id=73821 |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ Autoscroll should not stop on key press. |
+ |
+ Test: fast/events/autoscroll-should-not-stop-on-keypress.html |
+ |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::keyEvent): |
+ Removed the check for autoscroll so that autoscroll is not stopped on |
+ key press and key event is processed. |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ Add scrollAnimator getter method to WebScrollbarPainterDelegate |
+ https://bugs.webkit.org/show_bug.cgi?id=74146 |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate scrollAnimator]): |
+ (-[WebScrollbarPainterDelegate layer]): |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ |
+2011-12-08 James Robinson <jamesr@chromium.org> |
+ |
+ Improve handling of frame removal during requestAnimationFrame callback invocation |
+ https://bugs.webkit.org/show_bug.cgi?id=74036 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ See bug for details. |
+ |
+ Test: fast/animation/request-animation-frame-detach-element.html |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::removedLastRef): |
+ (WebCore::Document::detach): |
+ * dom/Document.h: |
+ * dom/ScriptedAnimationController.cpp: |
+ (WebCore::ScriptedAnimationController::~ScriptedAnimationController): |
+ (WebCore::ScriptedAnimationController::serviceScriptedAnimations): |
+ (WebCore::ScriptedAnimationController::scheduleAnimation): |
+ * dom/ScriptedAnimationController.h: |
+ (WebCore::ScriptedAnimationController::create): |
+ (WebCore::ScriptedAnimationController::clearDocumentPointer): |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::serviceScriptedAnimations): |
+ |
+2011-12-08 Yongjun Zhang <yongjun_zhang@apple.com> |
+ |
+ Use bitfield for bool data members in BitmapImage. |
+ https://bugs.webkit.org/show_bug.cgi?id=74102 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Class BitmapImage and FrameData has bool data members, we can use bitfield for those data |
+ members to reduce the BitmapImage's memory footprint. |
+ |
+ * platform/graphics/BitmapImage.cpp: |
+ (WebCore::BitmapImage::BitmapImage): |
+ * platform/graphics/BitmapImage.h: |
+ (WebCore::FrameData::FrameData): |
+ * platform/graphics/cairo/ImageCairo.cpp: |
+ (WebCore::BitmapImage::BitmapImage): |
+ * platform/graphics/cg/ImageCG.cpp: |
+ (WebCore::BitmapImage::BitmapImage): |
+ * platform/graphics/openvg/ImageOpenVG.cpp: |
+ (WebCore::BitmapImage::BitmapImage): |
+ * platform/graphics/qt/ImageQt.cpp: |
+ (WebCore::BitmapImage::BitmapImage): |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle |
+ https://bugs.webkit.org/show_bug.cgi?id=74145 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Call setHorizontalScrollerImp to set the horizontal scrollbar painter. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::updateScrollerStyle): |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ Create one WebScrollbarPainterDelegate for each scrollbar |
+ https://bugs.webkit.org/show_bug.cgi?id=74142 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go. |
+ This is a step towards simplifying the WebScrollbarPainterDelegate object. |
+ |
+ * platform/mac/ScrollAnimatorMac.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar): |
+ (WebCore::ScrollAnimatorMac::cancelAnimations): |
+ |
+2011-12-08 David Reveman <reveman@chromium.org> |
+ |
+ [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code. |
+ https://bugs.webkit.org/show_bug.cgi?id=74017 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Add per-tile drawing to page settings. |
+ |
+ No new tests. |
+ |
+ * page/Settings.h: |
+ (WebCore::Settings::setPerTileDrawingEnabled): |
+ (WebCore::Settings::perTileDrawingEnabled): |
+ * testing/Internals.cpp: |
+ (WebCore::Internals::setPerTileDrawingEnabled): |
+ * testing/Internals.h: |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ Add a scrollbarPainterForScrollbar helper function |
+ https://bugs.webkit.org/show_bug.cgi?id=74139 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (macScrollbarTheme): |
+ (scrollbarPainterForScrollbar): |
+ (WebCore::ScrollAnimatorMac::mouseEnteredScrollbar): |
+ (WebCore::ScrollAnimatorMac::mouseExitedScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar): |
+ |
+2011-12-08 James Robinson <jamesr@chromium.org> |
+ |
+ [chromium] Move NonCompositedContentHost to WebKit |
+ https://bugs.webkit.org/show_bug.cgi?id=74047 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include |
+ from LayerRendererChromium. |
+ |
+ * WebCore.gypi: |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ |
+2011-12-08 Sami Kyostila <skyostil@google.com> |
+ |
+ [chromium] Layer contents scale change should trigger invalidation |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=74086 |
+ |
+ When the contents scale of a layer is changed, the entire contents of |
+ the layer should be marked dirty. |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::setContentsScale): |
+ |
+2011-12-08 Stephen White <senorblanco@chromium.org> |
+ |
+ [chromium] Add CSS_FILTERS custom binding file to WebCore.gypi. |
+ https://bugs.webkit.org/show_bug.cgi?id=74091 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ If it builds, you're happy. |
+ |
+ * WebCore.gypi: |
+ |
+2011-12-08 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden |
+ https://bugs.webkit.org/show_bug.cgi?id=74126 |
+ |
+ Reviewed by Tony Chang. |
+ |
+ The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment |
+ pasted into textarea even though serialization algorithm in textarea doesn't handle block elements. |
+ |
+ Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this |
+ whole pre-rendering trick. |
+ |
+ * editing/markup.cpp: |
+ (WebCore::createFragmentFromText): |
+ |
+2011-12-08 Florin Malita <fmalita@google.com> |
+ |
+ Moving SVG elements on the page doesn't always erase element at the old position |
+ https://bugs.webkit.org/show_bug.cgi?id=74002 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: svg/repaint/container-repaint.svg |
+ |
+ * rendering/svg/RenderSVGContainer.cpp: |
+ (WebCore::RenderSVGContainer::layout): |
+ Save the old repaint bounds before updating the viewport. |
+ |
+2011-12-08 Tim Horton <timothy_horton@apple.com> |
+ |
+ Enable animations of CSS images using -webkit-cross-fade |
+ https://bugs.webkit.org/show_bug.cgi?id=74049 |
+ <rdar://problem/10209303> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ Add support for animating CSS images in the following properties: |
+ - background(-image) |
+ - border-image(-source) |
+ - list-style(-image) |
+ - -webkit-mask-box-image(-source) |
+ - -webkit-mask-image(-source) |
+ |
+ This patch only adds support for transitioning between NinePieceImages |
+ where all of the properties except the image itself are equal, and the |
+ size of the images are equal. Other cases will not animate. |
+ |
+ Add animation blend functions for StyleImage and NinePieceImage. |
+ |
+ Apply the proper compositing operation to -webkit-cross-fade, and |
+ fix handling of the destination and source areas to support scaling. |
+ |
+ Tests: animations/cross-fade-background-image.html |
+ animations/cross-fade-border-image-source.html |
+ animations/cross-fade-list-style-image.html |
+ animations/cross-fade-webkit-mask-box-image.html |
+ animations/cross-fade-webkit-mask-image.html |
+ |
+ * css/CSSCrossfadeValue.cpp: |
+ (WebCore::cachedImageForCSSValue): |
+ (WebCore::CSSCrossfadeValue::fixedSize): |
+ (WebCore::CSSCrossfadeValue::image): |
+ * css/CSSImageValue.cpp: |
+ (WebCore::CSSImageValue::CSSImageValue): |
+ * css/CSSImageValue.h: |
+ (WebCore::CSSImageValue::create): |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::crossfadeBlend): |
+ (WebCore::blendFunc): |
+ (WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper): |
+ (WebCore::RefCountedPropertyWrapper::blend): |
+ (WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper): |
+ (WebCore::FillLayerRefCountedPropertyWrapper::blend): |
+ (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): |
+ (WebCore::AnimationBase::ensurePropertyMap): |
+ (WebCore::addShorthandProperties): |
+ * platform/graphics/CrossfadeGeneratedImage.cpp: |
+ (WebCore::CrossfadeGeneratedImage::drawCrossfade): |
+ (WebCore::CrossfadeGeneratedImage::draw): |
+ (WebCore::CrossfadeGeneratedImage::drawPattern): |
+ * platform/graphics/CrossfadeGeneratedImage.h: |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::setMaskImage): |
+ |
+2011-12-08 Stephen White <senorblanco@chromium.org> |
+ |
+ Use Skia's implementation of Gaussian blur when accelerated filters |
+ are enabled. |
+ https://bugs.webkit.org/show_bug.cgi?id=73949 |
+ |
+ Reviewed by Zoltan Herczeg. |
+ |
+ In the future, this will be covered by the SVG tests run in GPU mode. |
+ |
+ * WebCore.gypi: |
+ Add FEGaussianBlurSkia.cpp to the build. |
+ * platform/graphics/filters/FEGaussianBlur.cpp: |
+ (WebCore::FEGaussianBlur::platformApplySoftware): |
+ Call out to platformApplySkia() when USE_SKIA is enabled. |
+ * platform/graphics/filters/FEGaussianBlur.h: |
+ platformApplySkia() declaration. |
+ * platform/graphics/filters/skia: Added. |
+ * platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added. |
+ (WebCore::FEGaussianBlur::platformApplySkia): |
+ On the Skia port, use SkBlurImageFilter for drawing |
+ Gaussian blurs in accelerated mode. |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::copyImage): |
+ Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics. |
+ |
+2011-12-08 Erik Arvidsson <arv@chromium.org> |
+ |
+ CodeGeneratorV8: Fix issue with overloaded static conditional methods |
+ https://bugs.webkit.org/show_bug.cgi?id=74114 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ The code generator was missing checks for Conditional for overloaded methods. |
+ |
+ * bindings/scripts/CodeGeneratorV8.pm: |
+ (GenerateOverloadedFunctionCallback): Generate needed #ifdefs. |
+ (GenerateFunctionCallback): Ditto. |
+ * bindings/scripts/test/V8/V8TestObj.cpp: Wrap conditional methods with #ifdefs. |
+ (WebCore::ConfigureV8TestObjTemplate): |
+ |
+2011-12-08 Dominic Mazzoni <dmazzoni@google.com> |
+ |
+ AccessibilityController should support listening to notifications on all elements. |
+ https://bugs.webkit.org/show_bug.cgi?id=72866 |
+ |
+ Changes accessibilitySetShouldRepostNotifications from an instance method |
+ into a class method so that it can be used for global notification listeners, |
+ not just for listeners on a particular object. |
+ |
+ Reviewed by Chris Fleizach. |
+ |
+ Test: accessibility/notification-listeners.html |
+ |
+ * accessibility/mac/WebAccessibilityObjectWrapper.h: |
+ * accessibility/mac/WebAccessibilityObjectWrapper.mm: |
+ (+[WebAccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]): |
+ (-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]): |
+ |
+2011-12-08 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector(). |
+ https://bugs.webkit.org/show_bug.cgi?id=74120 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * bindings/js/ScriptCallStackFactory.cpp: |
+ (WebCore::createScriptCallStackForInspector): |
+ * bindings/js/ScriptCallStackFactory.h: |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateParametersCheck): |
+ * bindings/scripts/CodeGeneratorV8.pm: |
+ (GenerateFunctionCallback): |
+ * bindings/scripts/test/JS/JSTestObj.cpp: |
+ (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): |
+ * bindings/scripts/test/V8/V8TestObj.cpp: |
+ (WebCore::TestObjInternal::customArgsAndExceptionCallback): |
+ * bindings/v8/ScriptCallStackFactory.cpp: |
+ (WebCore::createScriptCallStackForInspector): |
+ * bindings/v8/ScriptCallStackFactory.h: |
+ |
+2011-12-08 Adrienne Walker <enne@google.com> |
+ |
+ [chromium] Remove dead code in compositor |
+ https://bugs.webkit.org/show_bug.cgi?id=74103 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Tested via the compiler. |
+ |
+ * platform/graphics/chromium/LayerChromium.h: |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ |
+2011-12-08 Eric Penner <epenner@google.com> |
+ |
+ [chromium] Need to adjust memory limit and viewport multipliers. |
+ https://bugs.webkit.org/show_bug.cgi?id=74022 |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/graphics/chromium/TextureManager.cpp: |
+ (WebCore::TextureManager::highLimitBytes): Changing constants |
+ (WebCore::TextureManager::reclaimLimitBytes): ditto |
+ |
+2011-12-08 Benjamin Poulain <bpoulain@apple.com> |
+ |
+ Add a platform EventLoop for iOS |
+ https://bugs.webkit.org/show_bug.cgi?id=74043 |
+ |
+ Reviewed by David Kilzer. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/ios/EventLoopIOS.mm: Added. |
+ (WebCore::EventLoop::cycle): |
+ |
+2011-12-08 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: return node counts on the document / detached root basis |
+ https://bugs.webkit.org/show_bug.cgi?id=74104 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * bindings/js/ScriptProfiler.h: |
+ * bindings/v8/ScriptProfiler.cpp: |
+ (WebCore::ScriptProfiler::domNodeCount): |
+ * bindings/v8/ScriptProfiler.h: |
+ * inspector/Inspector.json: |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::InspectorController): |
+ * inspector/InspectorMemoryAgent.cpp: |
+ (WebCore::InspectorMemoryAgent::getDOMNodeCount): |
+ (WebCore::InspectorMemoryAgent::InspectorMemoryAgent): |
+ * inspector/InspectorMemoryAgent.h: |
+ (WebCore::InspectorMemoryAgent::create): |
+ |
+2011-12-08 Andreas Kling <kling@webkit.org> |
+ |
+ RenderObject: Rename styleSlowCase() to styleInRegion(). |
+ |
+ Rubber-stamped by David Hyatt. |
+ |
+ * WebCore.exp.in: |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::styleInRegion): |
+ * rendering/RenderObject.h: |
+ (WebCore::RenderObject::style): |
+ |
+2011-12-08 Andreas Kling <kling@webkit.org> |
+ |
+ Optimize RenderObject::containingBlock(). |
+ <http://webkit.org/b/74109> |
+ |
+ Reviewed by David Hyatt. |
+ |
+ When climbing the parent chain to locate the containing block-level element, |
+ use !isRenderBlock() to reject renderers rather than checking against an arbitrary |
+ list of non-block renderers and then rejecting anything that isn't a block anyway. |
+ |
+ RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com. |
+ This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().) |
+ |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::containingBlock): |
+ |
+2011-12-08 Nayan Kumar K <nayankk@motorola.com> |
+ |
+ Define DEBUG_GL_COMMANDS only in debug builds. |
+ https://bugs.webkit.org/show_bug.cgi?id=74083 |
+ |
+ Reviewed by Noam Rosenthal. |
+ |
+ No tests added as this change does not affect functionality. |
+ |
+ * platform/graphics/opengl/TextureMapperGL.cpp: |
+ |
+2011-12-08 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ CompositeEditCommand should not be kept alive for undo and redo |
+ https://bugs.webkit.org/show_bug.cgi?id=64414 |
+ |
+ Reviewed by Enrica Casucci. |
+ |
+ This patch introduces EditCommandComposition that replaces CompositeEditCommand for |
+ undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands |
+ to unapply and reapply edit commands that composes an undoable action. |
+ |
+ Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition, |
+ and applyCommandToComposite adds new SimpleEditCommands to the list. |
+ |
+ * editing/CompositeEditCommand.cpp: |
+ (WebCore::EditCommandComposition::create): |
+ (WebCore::EditCommandComposition::doApply): Never used. |
+ (WebCore::EditCommandComposition::doUnapply): |
+ (WebCore::EditCommandComposition::doReapply): |
+ (WebCore::EditCommandComposition::append): |
+ (WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create |
+ a composition for CompositeEditCommands that have parents. |
+ (WebCore::CompositeEditCommand::doUnapply): Never used. |
+ (WebCore::CompositeEditCommand::doReapply): Never used. |
+ (WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition. |
+ (WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition. |
+ |
+ * editing/CompositeEditCommand.h: |
+ (WebCore::EditCommandComposition::EditCommandComposition): |
+ (WebCore::CompositeEditCommand::composition): |
+ (WebCore::toEditCommandComposition): |
+ (WebCore::toCompositeEditCommand): |
+ |
+ * editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level |
+ commands are now required to be a CompositeEditCommand. |
+ (WebCore::RemoveTargetCommand::create): |
+ (WebCore::RemoveTargetCommand::RemoveTargetCommand): |
+ (WebCore::RemoveTargetCommand::doApply): |
+ (WebCore::DeleteButtonController::deleteTarget): |
+ |
+ * editing/EditCommand.cpp: |
+ (WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition. |
+ (WebCore::EditCommand::apply): Create a composition for a top-level command. |
+ (WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are |
+ added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition |
+ from SimpleEditCommand. Use isEditCommandComposition() instead. |
+ (WebCore::EditCommand::reapply): Ditto. |
+ (WebCore::compositionIfPossible): |
+ (WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition. |
+ (WebCore::EditCommand::setEndingSelection): Ditto. |
+ (WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in |
+ m_parent inside SimpleEditCommand when CompositeEditCommand goes away. |
+ |
+ * editing/EditCommand.h: |
+ (WebCore::EditCommand::isSimpleEditCommand): |
+ (WebCore::EditCommand::isCompositeEditCommand): |
+ (WebCore::EditCommand::isEditCommandComposition): |
+ (WebCore::EditCommand::parent): |
+ (WebCore::toSimpleEditCommand): |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand |
+ to the undo stack. |
+ (WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition. |
+ (WebCore::Editor::reappliedEditing): |
+ * editing/Editor.h: |
+ |
+2011-12-08 Stephen White <senorblanco@chromium.org> |
+ |
+ Add missing V8 bindings to get CSS_FILTERS to compile in Chromium. |
+ https://bugs.webkit.org/show_bug.cgi?id=74091 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Will be covered by tests in css3/filters (when enabled). |
+ |
+ * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added. |
+ (WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter): |
+ |
+2011-12-08 Beth Dakin <bdakin@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=73348 |
+ REGRESSION: Assertion when loading a page with a scrollable RenderLayer |
+ -and corresponding- |
+ <rdar://problem/10518918> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ The main problem here is that certain delegate calls into AppKit for overlay |
+ scrollbars can cause AppKit to call back into WebKit looking for more information. |
+ The assertion happens when WebKit tells AppKit that the scroll position has |
+ changed during a layout, and AppKit immediately asks WebKit to convert some |
+ coordinates, and WebKit asserts that you shouldn't do that while a layout is still |
+ happening. It's still possible for AppKit to call this delegate method while a |
+ layout is happening, and we should guard against that. This patch, however, does |
+ not do that. |
+ |
+ This change instead addresses the reason this assertion started happening much |
+ more frequently recently, which is that it recently became true that |
+ notifyPositionChanged() can be called when the position has not changed. To fix |
+ the assertion AND the bug that that change was intended to fix, we can just make |
+ sure that either the position OR the scroll origin has changed before calling |
+ notifyPositionChanged(). |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::immediateScrollToPoint): |
+ |
+ Call resetScrollOriginChanged() after the scroll instead of before so that we know |
+ whether or not to call notifyPositionChanged(). |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::updateScrollbars): |
+ |
+2011-12-08 Kaustubh Atrawalkar <kaustubh@motorola.com> |
+ |
+ Fixing support for static conditional overloaded functions. |
+ https://bugs.webkit.org/show_bug.cgi?id=74068 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateImplementation): Pushing "static" keyword after condition "#if". |
+ * bindings/scripts/test/CPP/WebDOMTestObj.cpp: |
+ (WebDOMTestObj::overloadedMethod1): Added newly generated bindings. |
+ * bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto. |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto. |
+ (webkit_dom_test_obj_overloaded_method1): |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto. |
+ * bindings/scripts/test/JS/JSTestObj.cpp: Ditto. |
+ (WebCore::jsTestObjConstructorFunctionOverloadedMethod11): |
+ (WebCore::jsTestObjConstructorFunctionOverloadedMethod12): |
+ (WebCore::jsTestObjConstructorFunctionOverloadedMethod1): |
+ * bindings/scripts/test/JS/JSTestObj.h: Ditto. |
+ * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto. |
+ * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto. |
+ (-[DOMTestObj overloadedMethod1:]): |
+ * bindings/scripts/test/TestObj.idl: Ditto. |
+ * bindings/scripts/test/V8/V8TestObj.cpp: Ditto. |
+ (WebCore::TestObjInternal::overloadedMethod11Callback): |
+ (WebCore::TestObjInternal::overloadedMethod12Callback): |
+ (WebCore::TestObjInternal::overloadedMethod1Callback): |
+ (WebCore::ConfigureV8TestObjTemplate): |
+ |
+2011-12-08 Andreas Kling <kling@webkit.org> |
+ |
+ Remove EventListenerMap destructor. |
+ <http://webkit.org/b/74096> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Let the compiler generate ~EventListenerMap(). We only needed it when the hash map |
+ was managing raw pointers. |
+ |
+ We're losing the no-iterators assertion from clear() by doing this, but that was |
+ superfluous to begin with - we were just using it to avoid duplicating code. |
+ |
+ * dom/EventListenerMap.cpp: |
+ * dom/EventListenerMap.h: |
+ |
+2011-12-08 Takashi Toyoshima <toyoshim@chromium.org> |
+ |
+ Provide more specific error description for SocketStreamError. |
+ https://bugs.webkit.org/show_bug.cgi?id=74066 |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ No new tests because this change just improve error messages for unexpected failures. |
+ |
+ * platform/network/soup/SocketStreamError.h: Add an argument for passing error description. |
+ (WebCore::SocketStreamError::SocketStreamError): |
+ * platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError. |
+ (WebCore::SocketStreamHandle::connected): |
+ (WebCore::SocketStreamHandle::readBytes): |
+ (WebCore::SocketStreamHandle::platformSend): |
+ (WebCore::SocketStreamHandle::platformClose): |
+ |
+2011-12-08 Mihnea Ovidenie <mihnea@adobe.com> |
+ |
+ [CSSRegions][CSSOM] Implement NamedFlow interface |
+ https://bugs.webkit.org/show_bug.cgi?id=66642 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Add WebKitNamedFlow to support the NamedFlow interface. No methods are |
+ yet implemented on this interface. The NamedFlow object is a live object. |
+ The first time user asks for it, it gets a valid JS object whose properties |
+ will reflect the changes to the flow thread. |
+ |
+ Tests: fast/regions/webkit-named-flow-existing-flow.html |
+ fast/regions/webkit-named-flow-flow-added.html |
+ fast/regions/webkit-named-flow-modified-flow.html |
+ fast/regions/webkit-named-flow-non-existing-flow.html |
+ fast/regions/webkit-named-flow-removed-flow.html |
+ fast/regions/webkit-named-flow-same-object.html |
+ |
+ * CMakeLists.txt: |
+ * DerivedSources.cpp: |
+ * DerivedSources.make: |
+ * DerivedSources.pri: |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/gobject/GNUmakefile.am: |
+ * dom/DOMAllInOne.cpp: |
+ * dom/Document.cpp: |
+ (WebCore::Document::webkitGetFlowByName): |
+ * dom/Document.h: |
+ * dom/Document.idl: |
+ * dom/NodeRenderingContext.cpp: |
+ (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded): |
+ * dom/WebKitNamedFlow.cpp: Added. |
+ (WebCore::WebKitNamedFlow::WebKitNamedFlow): |
+ (WebCore::WebKitNamedFlow::~WebKitNamedFlow): |
+ * dom/WebKitNamedFlow.h: Added. |
+ (WebCore::WebKitNamedFlow::create): |
+ * dom/WebKitNamedFlow.idl: Added. |
+ * rendering/RenderFlowThread.cpp: |
+ (WebCore::RenderFlowThread::ensureNamedFlow): |
+ * rendering/RenderFlowThread.h: |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::createObject): |
+ * rendering/RenderView.cpp: |
+ (WebCore::RenderView::ensureRenderFlowThreadWithName): |
+ * rendering/RenderView.h: |
+ |
+2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r102321. |
+ http://trac.webkit.org/changeset/102321 |
+ https://bugs.webkit.org/show_bug.cgi?id=74072 |
+ |
+ "Breaks all Chromium clobbered builds" (Requested by apavlov_ |
+ on #webkit). |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): |
+ * WebCore.gypi: |
+ * bindings/scripts/generate-bindings.pl: |
+ * page/DOMWindow.idl: |
+ * webaudio/DOMWindowWebAudio.idl: Removed. |
+ |
+2011-12-08 Shinya Kawanaka <shinyak@google.com> |
+ |
+ Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object. |
+ https://bugs.webkit.org/show_bug.cgi?id=74033 |
+ |
+ Reviewed by Hajime Morita. |
+ |
+ SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to |
+ pass necessary information to requestCheckingFor. |
+ |
+ No new tests. Covered by existing tests. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::replaceSelectionWithFragment): |
+ Uses the new interface. |
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto. |
+ * editing/SpellChecker.cpp: |
+ (WebCore::SpellCheckRequest::SpellCheckRequest): |
+ (WebCore::SpellCheckRequest::~SpellCheckRequest): |
+ (WebCore::SpellCheckRequest::create): |
+ Creates a new SpellCheckRequest object. |
+ (WebCore::SpellChecker::requestCheckingFor): |
+ Uses the new interface. |
+ (WebCore::SpellChecker::didCheck): |
+ * editing/SpellChecker.h: |
+ (WebCore::SpellCheckRequest::setSequence): |
+ (WebCore::SpellCheckRequest::sequence): |
+ (WebCore::SpellCheckRequest::checkingRange): |
+ (WebCore::SpellCheckRequest::paragraphRange): |
+ (WebCore::SpellCheckRequest::text): |
+ (WebCore::SpellCheckRequest::mask): |
+ (WebCore::SpellCheckRequest::rootEditableElement): |
+ |
+2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r102323. |
+ http://trac.webkit.org/changeset/102323 |
+ https://bugs.webkit.org/show_bug.cgi?id=74069 |
+ |
+ Caused Chromium and GTK build failure (Requested by bashi on |
+ #webkit). |
+ |
+ * testing/Internals.cpp: |
+ (WebCore::Internals::getPageScaleFactor): |
+ * testing/Internals.h: |
+ * testing/Internals.idl: |
+ |
+2011-12-08 Fady Samuel <fsamuel@chromium.org> |
+ |
+ Move scalePageBy from eventSender to window.internals |
+ https://bugs.webkit.org/show_bug.cgi?id=64512 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ Added setPageScaleFactor to window.internals. |
+ Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor |
+ to match the webkit style. |
+ |
+ * testing/Internals.cpp: |
+ (WebCore::Internals::pageScaleFactor): |
+ (WebCore::Internals::setPageScaleFactor): |
+ * testing/Internals.h: |
+ * testing/Internals.idl: |
+ |
+2011-12-08 Kentaro Hara <haraken@chromium.org> |
+ |
+ Use the [Supplemental] IDL for webaudio attributes in Chromium |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ - Overview: Using the [Supplemental] IDL, this patch moves the attribute |
+ declarations of webaudio from DOMWindow.idl into a new IDL file |
+ webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained |
+ feature (aka a module). |
+ |
+ - This patch changes the build flow of WebCore.gyp as follows: |
+ |
+ Previous build flow: |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl generates .h and .cpp files for $idl; |
+ } |
+ |
+ New build flow (See the discussions in bug 72138 for more details): |
+ resolve-supplemental.pl depends on all IDL files; |
+ resolve-supplemental.pl reads all IDL files; |
+ resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX]; |
+ resolve-supplemental.pl outputs supplemental_dependency.tmp; |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl and supplemental_dependency.tmp; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl reads supplemental_dependency.tmp; |
+ generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl; |
+ } |
+ |
+ - This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL |
+ will be removed after build scripts for all platforms support the [Supplemental] IDL. |
+ The motivation for the [Supplemented] IDL is as follows: |
+ |
+ In order to support the [Supplemental] IDL, we need to |
+ (1) run resolve-supplemental.pl and generate supplemental_dependency.tmp |
+ (2) and run generate-bindings.pl with the supplemental_dependency.tmp. |
+ |
+ This build flow requires a change on the following build scripts, |
+ but changing all the build scripts all at once without any regression is too difficult: |
+ |
+ - DerivedSources.make |
+ - DerivedSources.pri |
+ - GNUmakefile.am |
+ - PlatformBlackBerry.cmake |
+ - UseJSC.cmake |
+ - UseV8.cmake |
+ - WebCore.vcproj/MigrateScripts |
+ - WebCore.vcproj/WebCore.vcproj |
+ - bindings/gobject/GNUmakefile.am |
+ - WebCore.gyp/WebCore.gyp |
+ |
+ Thus, we are planning to change the build scripts one by one, which implies that |
+ we need to allow the temporary state in which some build scripts support [Supplemental] IDL |
+ but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented]. |
+ The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental] |
+ in another IDL file somewhere, like this: |
+ |
+ DOMWindowWebAudio.idl: |
+ interface [ |
+ Supplemental=DOMWindow |
+ ] DOMWindowWebAudio { |
+ attribute attr1; |
+ attribute attr2; |
+ }; |
+ |
+ DOMWindow.idl: |
+ interface [ |
+ ] DOMWindow { |
+ attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL |
+ attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL. |
+ attribute attr3; |
+ attribute attr4; |
+ }; |
+ |
+ Assuming these IDL files, this patch implements the following logic in generate-bindings.pl: |
+ |
+ - If a given build script supports the [Supplemental] IDL, |
+ generate-bindings.pl ignores all attributes with the [Supplemented] IDL. |
+ - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL |
+ as normal attributes and instead ignores all attributes with the [Supplemental] IDL |
+ (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL). |
+ |
+ Tests: webaudio/* |
+ |
+ * WebCore.gyp/WebCore.gyp: Describes the build flow that I described above. |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command. |
+ * WebCore.gypi: Added DOMWindowWebAudio.idl. |
+ * bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL. |
+ * page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL. |
+ * webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl. |
+ |
+2011-12-07 Yosifumi Inoue <yosin@chromium.org> |
+ |
+ CSS color gets adjusted for disabled input elements |
+ https://bugs.webkit.org/show_bug.cgi?id=54643 |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ No new tests. covered by existing tests. Need rebasing some existing tests for Chromimum. |
+ |
+ Remove automatic color adjustment for disabled text control for Chromimum. |
+ |
+ * css/themeChromium.css: Add CSS entries for default style for disabled input and textarea elements. |
+ * WebCore/rendering/RenderTextControl.cpp: |
+ (disabledTextColor): Removed for PLATFORM(CHROMIUM) |
+ (RenderTextControl::adjustInnerTextStyle): Don't call disabledTextColor for Chromium. |
+ |
+2011-12-07 Dmitry Lomov <dslomov@google.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=74038 |
+ [V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage. |
+ |
+ Reviewed by David Levin. |
+ |
+ * bindings/v8/custom/V8DOMWindowCustom.cpp: |
+ (WebCore::isLegacyTargetOriginDesignation): |
+ (WebCore::handlePostMessageCallback): |
+ |
+2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Upstream 4 files into WebCore/platform/blackberry |
+ https://bugs.webkit.org/show_bug.cgi?id=73541 |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ Initial upstream of BlackBerry porting of PlatformScreen/ |
+ SSLKeyGenerator/Sound/Widget, no new tests. |
+ |
+ * PlatformBlackBerry.cmake: Modified to remove empty file "WheelEventBlackBerry.cpp" |
+ * platform/blackberry/PlatformScreenBlackBerry.cpp: Added. |
+ (WebCore::screenIsMonochrome): |
+ (WebCore::screenDepthPerComponent): |
+ (WebCore::screenDepth): |
+ (WebCore::screenAvailableRect): |
+ (WebCore::screenRect): |
+ * platform/blackberry/SSLKeyGeneratorBlackBerry.cpp: Added. |
+ (WebCore::getSupportedKeySizes): |
+ (WebCore::signedPublicKeyAndChallengeString): |
+ * platform/blackberry/SoundBlackBerry.cpp: Added. |
+ (WebCore::systemBeep): |
+ * platform/blackberry/WidgetBlackBerry.cpp: Added. |
+ (WebCore::Widget::Widget): |
+ (WebCore::Widget::~Widget): |
+ (WebCore::Widget::hide): |
+ (WebCore::Widget::paint): |
+ (WebCore::Widget::setCursor): |
+ (WebCore::Widget::setFocus): |
+ (WebCore::Widget::setFrameRect): |
+ (WebCore::Widget::setIsSelected): |
+ (WebCore::Widget::show): |
+ (WebCore::Widget::frameRect): |
+ |
+2011-12-07 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ Refactor CSSParser::parseFontFaceSrc() |
+ https://bugs.webkit.org/show_bug.cgi?id=73989 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: fast/css/font-face-src-parsing.html |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseFontFaceSrcURI): Added. |
+ (WebCore::CSSParser::parseFontFaceSrcLocal): Added. |
+ (WebCore::CSSParser::parseFontFaceSrc): Rewrote. |
+ * css/CSSParser.h: |
+ |
+2011-12-07 Xingnan Wang <xingnan.wang@intel.com> |
+ |
+ Implement the SSE optimization in SincResampler::process() |
+ https://bugs.webkit.org/show_bug.cgi?id=73789 |
+ |
+ Reviewed by Benjamin Poulain. |
+ |
+ Here is about 70% performance improvement on the hot spot of sample convolving. |
+ |
+ * platform/audio/SincResampler.cpp: |
+ |
+2011-12-07 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Implement border image source properties in CSSStyleApplyProperty. |
+ https://bugs.webkit.org/show_bug.cgi?id=73981 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ No new tests / refactoring only. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyBorderImageSource::applyValue): |
+ (WebCore::ApplyPropertyBorderImageSource::createHandler): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ |
2011-12-07 Noel Gordon <noel.gordon@gmail.com> |
WebPImageDecoder should not do a full image decode if progressive decoding is active |