Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8992007: Make the repeating argument to timers optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/TimerTest.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b582a55376cc8cfaf77fac4b05cee27d067ea3d6..ca1fb7d8d2609b62bf826c75cea0a3a9ede408e4 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -236,7 +236,7 @@ class RunningProcess {
makeReadHandler(stdoutStringStream, stdout);
stderrStringStream.lineHandler =
makeReadHandler(stderrStringStream, stderr);
- timeoutTimer = new Timer(timeoutHandler, 1000 * testCase.timeout, false);
+ timeoutTimer = new Timer(timeoutHandler, 1000 * testCase.timeout);
}
void timeoutHandler(Timer unusedTimer) {
@@ -294,9 +294,7 @@ class DartcBatchRunnerProcess {
_testStderr = new List<String>();
_stdoutStream.lineHandler = _readOutput(_stdoutStream, _testStdout);
_stderrStream.lineHandler = _readOutput(_stderrStream, _testStderr);
- _timer = new Timer(_timeoutHandler(testCase),
- testCase.timeout * 1000,
- false);
+ _timer = new Timer(_timeoutHandler(testCase), testCase.timeout * 1000);
_process.stdin.write(_createArgumentsLine(testCase.arguments).charCodes());
}
« no previous file with comments | « tests/standalone/src/TimerTest.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698