third_party/libjingle/libjingle.gyp - Issue 8991010: This change updates the libjingle logging so that it writes to chromiums VLOG instead of its own ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libjingle/libjingle.gyp

Issue 8991010: This change updates the libjingle logging so that it writes to chromiums VLOG instead of its own ... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« jingle/glue/logging_unittest.cc ('K') | « remoting/jingle_glue/xmpp_socket_adapter.cc ('k') | third_party/libjingle/overrides/talk/base/logging.h » ('j') | third_party/libjingle/overrides/talk/base/logging.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libjingle/libjingle.gyp

===================================================================

--- third_party/libjingle/libjingle.gyp (revision 113136)

+++ third_party/libjingle/libjingle.gyp (working copy)

@@ -152,6 +152,7 @@

# SAFE_TO_DEFINE_TALK_BASE_LOGGING_MACROS to work.

Sergey Ulanov 2011/12/28 02:38:15 Update this comment.

hellner 2012/01/10 23:31:28 Done.

# TODO(sergeyu): push SAFE_TO_DEFINE_TALK_BASE_LOGGING_MACROS to

Sergey Ulanov 2011/12/28 02:38:15 this TODO is no longer relevant. Remove it?

hellner 2012/01/10 23:31:28 Done.

# libjingle and remove this override.

+ 'overrides/talk/base/logging.cc',

'overrides/talk/base/logging.h',

'overrides/talk/base/scoped_ptr.h',

@@ -212,7 +213,6 @@

'source/talk/base/json.cc',

'source/talk/base/json.h',

'source/talk/base/linked_ptr.h',

- 'source/talk/base/logging.cc',

'source/talk/base/md5.h',

'source/talk/base/md5c.c',

'source/talk/base/messagehandler.cc',