Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: webkit/fileapi/file_system_dir_url_request_job_unittest.cc

Issue 8991001: base::Bind: Convert most of webkit/appcache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix 2. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_dir_url_request_job_unittest.cc
diff --git a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc
index fb52cd2d453090398545e13ebe39d4a5d80ac052..e7871c83c0aa4014aa77b1ea6fce89e3b26d6897 100644
--- a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc
+++ b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc
@@ -281,21 +281,11 @@ TEST_F(FileSystemDirURLRequestJobTest, NoSuchDirectory) {
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request_->status().error());
}
-class QuitNowTask : public Task {
- public:
- virtual void Run() {
- MessageLoop::current()->QuitNow();
- }
-};
-
TEST_F(FileSystemDirURLRequestJobTest, Cancel) {
CreateDirectory("foo");
TestRequestNoRun(CreateFileSystemURL("foo/"));
// Run StartAsync() and only StartAsync().
- MessageLoop::current()->PostTask(FROM_HERE, new QuitNowTask);
- MessageLoop::current()->Run();
-
- request_.reset();
+ MessageLoop::current()->DeleteSoon(FROM_HERE, request_.release());
MessageLoop::current()->RunAllPending();
// If we get here, success! we didn't crash!
}
« no previous file with comments | « webkit/appcache/view_appcache_internals_job.cc ('k') | webkit/fileapi/file_system_url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698