Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: webkit/appcache/appcache_update_job_unittest.cc

Issue 8991001: base::Bind: Convert most of webkit/appcache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix 2. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_update_job.cc ('k') | webkit/appcache/appcache_url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_update_job_unittest.cc
diff --git a/webkit/appcache/appcache_update_job_unittest.cc b/webkit/appcache/appcache_update_job_unittest.cc
index 47b1d422ca9a7773a70e283df24b68ccd7eadbfb..1d6a4ec6b7fa93cb16fa5a1e5d64ff5ad83a9767 100644
--- a/webkit/appcache/appcache_update_job_unittest.cc
+++ b/webkit/appcache/appcache_update_job_unittest.cc
@@ -978,18 +978,16 @@ class AppCacheUpdateJobTest : public testing::Test,
const std::string seed_data(kManifest1Contents);
scoped_refptr<net::StringIOBuffer> io_buffer(
new net::StringIOBuffer(seed_data));
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteData(io_buffer, seed_data.length(),
- write_callback_.get());
+ response_writer_->WriteData(
+ io_buffer, seed_data.length(),
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
void StartUpdateAfterSeedingStorageData(int result) {
ASSERT_GT(result, 0);
- write_callback_.reset();
response_writer_.reset();
AppCacheUpdateJob* update = group_->update_job_;
@@ -1104,11 +1102,10 @@ class AppCacheUpdateJobTest : public testing::Test,
const std::string seed_data("different");
scoped_refptr<net::StringIOBuffer> io_buffer(
new net::StringIOBuffer(seed_data));
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteData(io_buffer, seed_data.length(),
- write_callback_.get());
+ response_writer_->WriteData(
+ io_buffer, seed_data.length(),
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
@@ -1167,10 +1164,10 @@ class AppCacheUpdateJobTest : public testing::Test,
response_info->headers = headers; // adds ref to headers
scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
new HttpResponseInfoIOBuffer(response_info)); // adds ref to info
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteInfo(io_buffer, write_callback_.get());
+ response_writer_->WriteInfo(
+ io_buffer,
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
@@ -1226,10 +1223,10 @@ class AppCacheUpdateJobTest : public testing::Test,
response_info->headers = headers; // adds ref to headers
scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
new HttpResponseInfoIOBuffer(response_info)); // adds ref to info
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteInfo(io_buffer, write_callback_.get());
+ response_writer_->WriteInfo(
+ io_buffer,
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
@@ -1285,10 +1282,10 @@ class AppCacheUpdateJobTest : public testing::Test,
response_info->headers = headers; // adds ref to headers
scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
new HttpResponseInfoIOBuffer(response_info)); // adds ref to info
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteInfo(io_buffer, write_callback_.get());
+ response_writer_->WriteInfo(
+ io_buffer,
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
@@ -2666,10 +2663,10 @@ class AppCacheUpdateJobTest : public testing::Test,
response_info->headers = headers; // adds ref to headers
scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
new HttpResponseInfoIOBuffer(response_info)); // adds ref to info
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteInfo(io_buffer, write_callback_.get());
+ response_writer_->WriteInfo(
+ io_buffer,
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
@@ -2725,10 +2722,10 @@ class AppCacheUpdateJobTest : public testing::Test,
response_info->headers = headers; // adds ref to headers
scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
new HttpResponseInfoIOBuffer(response_info)); // adds ref to info
- write_callback_.reset(
- new net::OldCompletionCallbackImpl<AppCacheUpdateJobTest>(this,
- &AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData));
- response_writer_->WriteInfo(io_buffer, write_callback_.get());
+ response_writer_->WriteInfo(
+ io_buffer,
+ base::Bind(&AppCacheUpdateJobTest::StartUpdateAfterSeedingStorageData,
+ base::Unretained(this)));
// Start update after data write completes asynchronously.
}
@@ -3230,8 +3227,6 @@ class AppCacheUpdateJobTest : public testing::Test,
scoped_ptr<base::WaitableEvent> event_;
scoped_ptr<AppCacheResponseWriter> response_writer_;
- scoped_ptr<net::OldCompletionCallbackImpl<AppCacheUpdateJobTest> >
- write_callback_;
// Hosts used by an async test that need to live until update job finishes.
// Otherwise, test can put host on the stack instead of here.
« no previous file with comments | « webkit/appcache/appcache_update_job.cc ('k') | webkit/appcache/appcache_url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698