Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: webkit/appcache/appcache_storage_impl.cc

Issue 8991001: base::Bind: Convert most of webkit/appcache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix 2. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_storage_impl.h ('k') | webkit/appcache/appcache_update_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_storage_impl.cc
diff --git a/webkit/appcache/appcache_storage_impl.cc b/webkit/appcache/appcache_storage_impl.cc
index b374093e068f662adbcf888882fdc753cf06504c..e2a0b2697f5f64b2c939352ca27661147bb52810 100644
--- a/webkit/appcache/appcache_storage_impl.cc
+++ b/webkit/appcache/appcache_storage_impl.cc
@@ -1208,10 +1208,6 @@ AppCacheStorageImpl::AppCacheStorageImpl(AppCacheService* service)
is_response_deletion_scheduled_(false),
did_start_deleting_responses_(false),
last_deletable_response_rowid_(0),
- ALLOW_THIS_IN_INITIALIZER_LIST(doom_callback_(
- this, &AppCacheStorageImpl::OnDeletedOneResponse)),
- ALLOW_THIS_IN_INITIALIZER_LIST(init_callback_(
- this, &AppCacheStorageImpl::OnDiskCacheInitialized)),
database_(NULL), is_disabled_(false),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
}
@@ -1596,7 +1592,9 @@ void AppCacheStorageImpl::DeleteOneResponse() {
// TODO(michaeln): add group_id to DoomEntry args
int64 id = deletable_response_ids_.front();
- int rv = disk_cache_->DoomEntry(id, &doom_callback_);
+ int rv = disk_cache_->DoomEntry(
+ id, base::Bind(&AppCacheStorageImpl::OnDeletedOneResponse,
+ base::Unretained(this)));
if (rv != net::ERR_IO_PENDING)
OnDeletedOneResponse(rv);
}
@@ -1682,11 +1680,15 @@ AppCacheDiskCache* AppCacheStorageImpl::disk_cache() {
disk_cache_.reset(new AppCacheDiskCache);
if (is_incognito_) {
rv = disk_cache_->InitWithMemBackend(
- kMaxMemDiskCacheSize, &init_callback_);
+ kMaxMemDiskCacheSize,
+ base::Bind(&AppCacheStorageImpl::OnDiskCacheInitialized,
+ base::Unretained(this)));
} else {
rv = disk_cache_->InitWithDiskBackend(
cache_directory_.Append(kDiskCacheDirectoryName),
- kMaxDiskCacheSize, false, cache_thread_, &init_callback_);
+ kMaxDiskCacheSize, false, cache_thread_,
+ base::Bind(&AppCacheStorageImpl::OnDiskCacheInitialized,
+ base::Unretained(this)));
}
// We should not keep this reference around.
« no previous file with comments | « webkit/appcache/appcache_storage_impl.h ('k') | webkit/appcache/appcache_update_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698