Issue 8991: Always show file extensions in the shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8991: Always show file extensions in the shelf. (Closed)

Created:
12 years, 1 month ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Always show file extensions in the shelf. BUG=1208 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4450

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -12 lines)			Patch
M	base/file_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/file_util.cc	View	1 2 3 4	1 chunk	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/views/download_item_view.cc	View	1 2 3 4	3 chunks	+64 lines, -7 lines	0 comments	Download
M	chrome/common/gfx/chrome_canvas.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/gfx/chrome_canvas.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

12 years, 1 month ago (2008-11-01 00:14:05 UTC) #2

LG just a couple of small nits

http://codereview.chromium.org/8991/diff/1/3
File base/file_util.cc (right):

http://codereview.chromium.org/8991/diff/1/3#newcode98
Line 98: return std::wstring(last_dot == std::wstring::npos? L"" : file_name,
last_dot+1);
nit: space before ?

http://codereview.chromium.org/8991/diff/1/4
File chrome/browser/views/download_item_view.cc (right):

http://codereview.chromium.org/8991/diff/1/4#newcode458
Line 458: // Extract the file extension (if any).
you might explain what your general strategy is here... it wasn't immediately
obvious to me why this code is so complicated (it's because windows does the
eliding)

http://codereview.chromium.org/8991/diff/1/4#newcode466
Line 466: ChromeCanvas::NO_ELLIPSIS);
indent to (, it'll fit

Expand Messages | Collapse Messages