Issue 8989068: Remove old DCHECK from ~PepperStreamChannel().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8989068: Remove old DCHECK from ~PepperStreamChannel(). (Closed)

Created:
8 years, 12 months ago by Sergey Ulanov

Modified:
8 years, 11 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove old DCHECK from ~PepperStreamChannel(). Now channel_ can be owned by the ChannelAuthenticator, so the assumption verified by this DCHECK is not valid anymore. BUG=105214 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116105

Patch Set 1 #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	remoting/protocol/pepper_stream_channel.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8989068/1

8 years, 11 months ago (2012-01-01 21:33:34 UTC) #3

commit-bot: I haz the power

8 years, 11 months ago (2012-01-01 23:24:23 UTC) #4

Try job failure for 8989068-1 (retry) (retry) on win_rel for step
"base_unittests" (clobber build).
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages