Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 8989061: Add ___asan_unregister_globals to the list of symbols that should be saved when building with Add... (Closed)

Created:
8 years, 12 months ago by Alexander Potapenko
Modified:
8 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, kcc2, inferno
Visibility:
Public.

Description

Add ___asan_unregister_globals to the list of symbols that should be saved when building with AddressSanitizer. This CL is to be submitted after we update the ASan binaries for Darwin. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/asan.saves View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/app_asan.saves View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Please take a look.
8 years, 12 months ago (2011-12-28 15:46:44 UTC) #1
Mark Mentovai
LGTM I’m actually on vacation until the 5th. If you have more reviews before then, ...
8 years, 12 months ago (2011-12-28 15:51:30 UTC) #2
Alexander Potapenko
On 2011/12/28 15:51:30, Mark Mentovai wrote: > LGTM > > I’m actually on vacation until ...
8 years, 12 months ago (2011-12-28 15:54:38 UTC) #3
Alexander Potapenko
8 years, 12 months ago (2011-12-29 13:29:10 UTC) #4
+Kostya, Abhishek
Folks, FYI. This change is required for the binaries from
http://codereview.chromium.org/9034019/
It's incompatible with the previous ASan-Mac binaries.
It does not affect Linux or Chrome OS

Powered by Google App Engine
This is Rietveld 408576698