Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 8989047: WebSocket Pepper API: add a unit test for the bufferedAmount property (Closed)

Created:
8 years, 12 months ago by Takashi Toyoshima
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

WebSocket Pepper API: add a unit test for the bufferedAmount property Add a unit test for the bufferedAmount property to verify its behaviors around connection close. BUG=87310 TEST=ui_test --gtest_filter='PPAPITest.WebSocket_BufferedAmount' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117415

Patch Set 1 #

Patch Set 2 : up to date #

Total comments: 8

Patch Set 3 : fix reviewed points #

Total comments: 1

Patch Set 4 : typo #

Patch Set 5 : rebase to handle the conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -5 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_websocket.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_websocket.cc View 1 2 3 4 3 chunks +67 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Takashi Toyoshima
I'd like to add a bufferedAmount property computation unit test. Could you review this change?
8 years, 11 months ago (2012-01-10 12:10:01 UTC) #1
dmichael (off chromium)
http://codereview.chromium.org/8989047/diff/2001/ppapi/tests/test_websocket.cc File ppapi/tests/test_websocket.cc (right): http://codereview.chromium.org/8989047/diff/2001/ppapi/tests/test_websocket.cc#newcode491 ppapi/tests/test_websocket.cc:491: // Prepare a large message unfitting internal buffer sizes. ...
8 years, 11 months ago (2012-01-11 05:01:57 UTC) #2
Takashi Toyoshima
Thanks http://codereview.chromium.org/8989047/diff/2001/ppapi/tests/test_websocket.cc File ppapi/tests/test_websocket.cc (right): http://codereview.chromium.org/8989047/diff/2001/ppapi/tests/test_websocket.cc#newcode491 ppapi/tests/test_websocket.cc:491: // Prepare a large message unfitting internal buffer ...
8 years, 11 months ago (2012-01-11 05:50:28 UTC) #3
dmichael (off chromium)
lgtm http://codereview.chromium.org/8989047/diff/4002/ppapi/tests/test_websocket.cc File ppapi/tests/test_websocket.cc (right): http://codereview.chromium.org/8989047/diff/4002/ppapi/tests/test_websocket.cc#newcode504 ppapi/tests/test_websocket.cc:504: // Buffered amount size 262144 is enough big ...
8 years, 11 months ago (2012-01-12 03:46:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8989047/12002
8 years, 11 months ago (2012-01-12 04:23:27 UTC) #5
commit-bot: I haz the power
Can't apply patch for file ppapi/tests/test_websocket.cc. While running patch -p1 --forward --force; patching file ppapi/tests/test_websocket.cc ...
8 years, 11 months ago (2012-01-12 07:04:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8989047/18003
8 years, 11 months ago (2012-01-12 07:18:22 UTC) #7
commit-bot: I haz the power
Try job failure for 8989047-18003 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 11 months ago (2012-01-12 09:34:27 UTC) #8
Takashi Toyoshima
not related tests seem to be flaky. I'll retry.
8 years, 11 months ago (2012-01-12 09:36:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8989047/18003
8 years, 11 months ago (2012-01-12 09:36:52 UTC) #10
commit-bot: I haz the power
8 years, 11 months ago (2012-01-12 10:54:00 UTC) #11
Change committed as 117415

Powered by Google App Engine
This is Rietveld 408576698